You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Olabusayo Kilo (Jira)" <ji...@apache.org> on 2023/01/03 18:15:00 UTC
[jira] [Comment Edited] (DAFFODIL-2275) Configure Daffodil to use Sonarqube/Sonarcloud.io
[ https://issues.apache.org/jira/browse/DAFFODIL-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046873#comment-17046873 ]
Olabusayo Kilo edited comment on DAFFODIL-2275 at 1/3/23 6:14 PM:
------------------------------------------------------------------
||Task||Status||
|Fix projectKey typo| Fixed in 5516f2542e5d75174b9e2fd417a7a99ebbd0bc3c|
|Update confirmations from test instance to reflect in main instance| Done|
|Look into test classes name convention rule|Done |
|Look into Java classes with test in the name| Done|
|Investigate empty methods; adding comments as necessary| Fixed in 5e63af1f5e0cd268b84e9de9735baac19310aeff|
|Increase Cognitive complexity rule threshold to 100| Done|
|Create bugs for regex string duplications and turn rule off| Done|
|Update convention for constant names to be upper camel case (incl enums and obj)| Done|
|Look into commented out code: if no comment on why, remove. If commented, look into structured comment that can be added so it's ignored|Fixed in 5e63af1f5e0cd268b84e9de9735baac19310aeff |
|For XML of comment out code: mark ./apache/daffodil/xsd/XMLSchem issues as Won't fix| Done|
|Turn off rule for collapsible ifs| Done|
|There is a ticket for FIXME/TODO rules; go through list and confirm|Issue is tracked in Sonarcloud|
|Create bug to look into and fix all unused function params| Done|
|Mark all "function param count is too large" issues as won't fix| Done|
|Create bug report for duplicated code blocks| Fixed in 5acd1777e88245626cea77ea8ce3e7df80c0fdad,
7be19a16eaf6a50cb22dd03f75ac16eee208b663|
|Remove "Match case count too large rule" and mark current as false positive if needed|Done |
|Try turning on sbt unused and see how many warnings we get|No longer needed|
|Investigate unused private functions / create bug report as necessary|Issue is tracked in Sonarcloud|
|Add comments for empty code block| Fixed in 075ed018d786d332deddc5e20169939f95470fef|
|Update method name to match scala convention; add something in particular for test cases ("test_" prefix) rather than just arbitrarily allowing underscores| Done|
|Mark current boolean literal issues as "Won't Fix"| Done|
|Update local var/para's naming convention to match Scala's naming convention| Done|
|Investigate unused local params; might need bug report| Done|
|Fix out of order modifiers on functions|Done. Issue doesn't appear in SonarCloud.io|
|Fix != operator issue|Issue is tracked in [Sonarcloud\|https://sonarcloud.io/project/issues?resolved=false&rules=scala%3AS1940&types=CODE_SMELL&id=apache-daffodil]|
was (Author: okilo@tresys.com):
||Task||Status||
|Fix projectKey typo| Fixed in 5516f2542e5d75174b9e2fd417a7a99ebbd0bc3c|
|Update confirmations from test instance to reflect in main instance| Done|
|Look into test classes name convention rule|Done |
|Look into Java classes with test in the name| Done|
|Investigate empty methods; adding comments as necessary| Fixed in 5e63af1f5e0cd268b84e9de9735baac19310aeff|
|Increase Cognitive complexity rule threshold to 100| Done|
|Create bugs for regex string duplications and turn rule off| Done|
|Update convention for constant names to be upper camel case (incl enums and obj)| Done|
|Look into commented out code: if no comment on why, remove. If commented, look into structured comment that can be added so it's ignored|Fixed in 5e63af1f5e0cd268b84e9de9735baac19310aeff |
|For XML of comment out code: mark ./apache/daffodil/xsd/XMLSchem issues as Won't fix| Done|
|Turn off rule for collapsible ifs| Done|
|There is a ticket for FIXME/TODO rules; go through list and confirm| |
|Create bug to look into and fix all unused function params| Done|
|Mark all "function param count is too large" issues as won't fix| Done|
|Create bug report for duplicated code blocks| Fixed in 5acd1777e88245626cea77ea8ce3e7df80c0fdad,
7be19a16eaf6a50cb22dd03f75ac16eee208b663|
|Remove "Match case count too large rule" and mark current as false positive if needed|Done |
|Try turning on sbt unused and see how many warnings we get| |
|Investigate unused private functions / create bug report as necessary| |
|Add comments for empty code block| Fixed in 075ed018d786d332deddc5e20169939f95470fef|
|Update method name to match scala convention; add something in particular for test cases ("test_" prefix) rather than just arbitrarily allowing underscores| Done|
|Mark current boolean literal issues as "Won't Fix"| Done|
|Update local var/para's naming convention to match Scala's naming convention| Done|
|Investigate unused local params; might need bug report| Done|
|Fix out of order modifiers on functions| |
|Fix != operator issue| |
> Configure Daffodil to use Sonarqube/Sonarcloud.io
> -------------------------------------------------
>
> Key: DAFFODIL-2275
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2275
> Project: Daffodil
> Issue Type: Improvement
> Components: Infrastructure
> Reporter: Olabusayo Kilo
> Assignee: Olabusayo Kilo
> Priority: Major
>
> We want to integrate Sonarqube into our development workflow, using Github Actions. We're awaiting creation on Apache's Sonarcloud.io https://issues.apache.org/jira/browse/INFRA-19812 , after which, we can proceed with configuring Github Actions to add this functionality.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)