You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by eranwitkon <gi...@git.apache.org> on 2015/08/31 07:52:16 UTC
[GitHub] incubator-zeppelin pull request: Zeppelin-272: Remove option part ...
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/266
Zeppelin-272: Remove option part from REST API
This PR remove the option part from the Interpreter setting REST API
[x] Remove option from list settings
[x] Remove option from Create settings and update settings
[X] Update Create setting to return new created setting (jira 261) replacing pr # 258
Remove option from list setting is done by implementing a Exclusion strategy for the gson serialization.
Remove option from the Create\Update REST API is done by passing new InterpreterOption(remote=true) the the Factory and by omitting the InterpreterOption from the NewInterpreterSetting and UpdateInterpreterSetting classes.
REST API tests are managed in another
Update to the documentation will be done in a separate PR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eranwitkon/incubator-zeppelin 272
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/266.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #266
----
commit b98006917f023aaa442e07b3e98d2cba2e942f04
Author: eranwitkon <go...@gmail.com>
Date: 2015-08-30T11:53:18Z
Added exclusion strategy class for gson to exclude InterpreterOption from response.
JsonResponse was updated accordingly to apply this strategy
commit 14e88097553d11cd7e449f66d9ac7ec52b583690
Author: eranwitkon <go...@gmail.com>
Date: 2015-08-30T13:45:36Z
Remove InterpreterOption class from NewInterpreterSettingRequest and UpdatedInterpreterSettingRequest.
Updated InterpreterRestAPI to send new InterpreterOption(remote=true) as option to Interpreter factory.
commit f2178f68b853667a68d537d6e6810e6b8d825a07
Author: eranwitkon <go...@gmail.com>
Date: 2015-08-31T05:47:11Z
Remove InterpreterOption class from NewInterpreterSettingRequest and UpdatedInterpreterSettingRequest.
Updated InterpreterRestAPI to send new InterpreterOption(remote=true) as option to Interpreter factory.
Rebase with PR #261 to return new created settings for REST API
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-272: Remove option part ...
Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/266#issuecomment-136810321
I will have a look at this as well although the PR is about the REST API
and as much as I tested this controller is not part of it.
בתאריך יום ג׳, 1 בספט׳ 2015, 20:43 מאת Lee moon soo <
notifications@github.com>:
> I think these lines also need to be taken care
>
> https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-web/src/app/interpreter/interpreter.controller.js#L67
>
> https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-web/src/app/interpreter/interpreter.controller.js#L172
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-zeppelin/pull/266#issuecomment-136809023>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-272: Remove option part ...
Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/266#issuecomment-136645152
Fixed RAT issue.
Ready for merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-272: Remove option part ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/266#issuecomment-136951436
merging if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-272: Remove option part ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-272: Remove option part ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/266#issuecomment-136809023
I think these lines also need to be taken care
https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-web/src/app/interpreter/interpreter.controller.js#L67
https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-web/src/app/interpreter/interpreter.controller.js#L172
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---