[jira] [Updated] (TS-2618) IOBufferBlock::realloc()'s bounds check is wrong

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom updated TS-2618:
------------------------------

    Description: 
Presumably this never fires, but:
{code}
 if (i >= (int64_t) sizeof(ioBufAllocator))
    return;
{code}

looks wrong, it looks like i is an index into that array, so it should be

{code}
i >= SIZE(ioBufAllocator))
{code}

(SIZE() from ink_defs.h)



  was:
Presumably this never fires, but:
 if (i >= (int64_t) sizeof(ioBufAllocator))
    return;

looks wrong, it looks like i is an index into that array, so it should be i >= SIZE(ioBufAllocator))
(SIZE() from ink_defs.h)




> IOBufferBlock::realloc()'s bounds check is wrong
> ------------------------------------------------
>
>                 Key: TS-2618
>                 URL: https://issues.apache.org/jira/browse/TS-2618
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core
>            Reporter: William Bardwell
>            Assignee: William Bardwell
>             Fix For: 5.0.0
>
>
> Presumably this never fires, but:
> {code}
>  if (i >= (int64_t) sizeof(ioBufAllocator))
>     return;
> {code}
> looks wrong, it looks like i is an index into that array, so it should be
> {code}
> i >= SIZE(ioBufAllocator))
> {code}
> (SIZE() from ink_defs.h)



--
This message was sent by Atlassian JIRA
(v6.2#6252)