You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/13 08:04:19 UTC

[GitHub] [calcite] rubenada commented on a change in pull request #2023: [CALCITE-4057] Implement trait propagation for EnumerableBatchNestedL…

rubenada commented on a change in pull request #2023:
URL: https://github.com/apache/calcite/pull/2023#discussion_r439719710



##########
File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableTraitsUtils.java
##########
@@ -148,4 +149,53 @@ private static boolean isCollationOnTrivialExpr(
       return null;
     }
   }
+
+  // This function can be reused when a Join's traits pass-down shall only

Review comment:
       minor detail: I think it would be better to use javadoc comment here (instead of line comment). Same for `deriveTraitsForJoin`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org