You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/13 09:33:50 UTC
[GitHub] [airflow] penggongkui opened a new pull request #13647: [AIRFLOW-6076] fix dag.cli() KeyError
penggongkui opened a new pull request #13647:
URL: https://github.com/apache/airflow/pull/13647
fix this issue: https://issues.apache.org/jira/browse/AIRFLOW-6076
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13647: [AIRFLOW-6076] fix dag.cli() KeyError
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13647:
URL: https://github.com/apache/airflow/pull/13647#issuecomment-761580057
CI is green, but it still needs tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13647: [AIRFLOW-6076] fix dag.cli() KeyError
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13647:
URL: https://github.com/apache/airflow/pull/13647#issuecomment-759419270
[The Workflow run](https://github.com/apache/airflow/actions/runs/482655296) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13647: [AIRFLOW-6076] fix dag.cli() KeyError
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13647:
URL: https://github.com/apache/airflow/pull/13647#issuecomment-801842373
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13647: [AIRFLOW-6076] fix dag.cli() KeyError
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13647:
URL: https://github.com/apache/airflow/pull/13647#issuecomment-759948699
[The Workflow run](https://github.com/apache/airflow/actions/runs/484624745) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] penggongkui commented on pull request #13647: [AIRFLOW-6076] fix dag.cli() KeyError
Posted by GitBox <gi...@apache.org>.
penggongkui commented on pull request #13647:
URL: https://github.com/apache/airflow/pull/13647#issuecomment-761298546
Ok，could you please help me pass the ci error , I don't know what to do to
fix it
On Sat, Jan 16, 2021, 05:59 Kamil Breguła <no...@github.com> wrote:
> Can you add tests to avoid regression? Besides, thanks a lot for fixing
> this bug. This is not the first time we've tried to fix this, but I hope
> we'll have success this time.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/airflow/pull/13647#issuecomment-761220444>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALW4V63XNXKRODXZXQNJI3LS2C3CRANCNFSM4WAQHNRA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] penggongkui commented on pull request #13647: [AIRFLOW-6076] fix dag.cli() KeyError
Posted by GitBox <gi...@apache.org>.
penggongkui commented on pull request #13647:
URL: https://github.com/apache/airflow/pull/13647#issuecomment-762231800
I have added some test cases
> CI is green, but it still needs tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13647: [AIRFLOW-6076] fix dag.cli() KeyError
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13647:
URL: https://github.com/apache/airflow/pull/13647#issuecomment-761220444
Can you add tests to avoid regression? Besides, thanks a lot for fixing this bug. This is not the first time we've tried to fix this, but I hope we'll have success this time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13647: [AIRFLOW-6076] fix dag.cli() KeyError
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13647:
URL: https://github.com/apache/airflow/pull/13647#issuecomment-759920605
[The Workflow run](https://github.com/apache/airflow/actions/runs/484474022) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13647: [AIRFLOW-6076] fix dag.cli() KeyError
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13647:
URL: https://github.com/apache/airflow/pull/13647#issuecomment-759325947
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] penggongkui removed a comment on pull request #13647: [AIRFLOW-6076] fix dag.cli() KeyError
Posted by GitBox <gi...@apache.org>.
penggongkui removed a comment on pull request #13647:
URL: https://github.com/apache/airflow/pull/13647#issuecomment-761298546
Ok，could you please help me pass the ci error , I don't know what to do to
fix it
On Sat, Jan 16, 2021, 05:59 Kamil Breguła <no...@github.com> wrote:
> Can you add tests to avoid regression? Besides, thanks a lot for fixing
> this bug. This is not the first time we've tried to fix this, but I hope
> we'll have success this time.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/airflow/pull/13647#issuecomment-761220444>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALW4V63XNXKRODXZXQNJI3LS2C3CRANCNFSM4WAQHNRA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #13647: [AIRFLOW-6076] fix dag.cli() KeyError
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #13647:
URL: https://github.com/apache/airflow/pull/13647
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] penggongkui commented on pull request #13647: [AIRFLOW-6076] fix dag.cli() KeyError
Posted by GitBox <gi...@apache.org>.
penggongkui commented on pull request #13647:
URL: https://github.com/apache/airflow/pull/13647#issuecomment-781002984
@mik-laj could you please review this PR
how about add this to the 2.0.2 milestone
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org