You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "AT-Fieldless (Jira)" <ji...@apache.org> on 2019/11/14 03:28:00 UTC

[jira] [Commented] (FLINK-14733) Introduce ResourceProfile builder to enable flexible building

    [ https://issues.apache.org/jira/browse/FLINK-14733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973904#comment-16973904 ] 

AT-Fieldless commented on FLINK-14733:
--------------------------------------

Hi Zhu Zhu, I'm interested in this issue. I think I can solve it by introduce a ResourceProfileBuilder class with two constructors, one support raw types and the other support advanced types

> Introduce ResourceProfile builder to enable flexible building
> -------------------------------------------------------------
>
>                 Key: FLINK-14733
>                 URL: https://issues.apache.org/jira/browse/FLINK-14733
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>    Affects Versions: 1.10.0
>            Reporter: Zhu Zhu
>            Priority: Major
>             Fix For: 1.10.0
>
>
> The ResourceProfile constructors may accept values in raw types (double/int) or advanced types(CPUResource/MemorySize). Thus it had to maintain different kinds of constructors for the combinations. Or one may need to build advanced values types from raw types to use construct ResourceProfile.
> I'd propose to introduce a builder to enable flexible building of ResourceProfile. It allows setting a resource with advanced value types as well as raw value types.
> The builder will also make it easier to see what resource is set.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)