[GitHub] [activemq] ehossack-aws commented on a change in pull request #647: [AMQ-7442] Support JDK11 full build and code style

[GitBox <gi...@apache.org>]

ehossack-aws commented on a change in pull request #647:
URL: https://github.com/apache/activemq/pull/647#discussion_r636311116



##########
File path: activemq-http/src/test/java/org/apache/activemq/transport/https/HttpsClientSettingsHostnameVerificationDisabledTest.java
##########
@@ -93,7 +93,13 @@ protected ActiveMQConnectionFactory createConnectionFactory()
 
         return factory;
     }
-    
-
 
+    @Override
+    public void runBare() throws Throwable {
+        try {
+            super.runBare();
+        } catch (Exception e) {
+            e.printStackTrace();

Review comment:
       So isn't this effectively suppressing any test failures? I don't have a deep understanding, but `runBare` should call `runTest` do setup/teardown then propagate the exception -> so if the test throws some error, won't we just miss it?
   
   Not sure this was intended to be part of this CR because you couldn't just `@Ignore` :P 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org