You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "pivotal-jbarrett (GitHub)" <gi...@apache.org> on 2019/01/22 14:53:09 UTC
[GitHub] [geode-native] pivotal-jbarrett opened pull request #437:
GEODE-2484: Remove more ACE and cleanup
[ Full content available at: https://github.com/apache/geode-native/pull/437 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on pull request #437:
GEODE-2484: Remove more ACE and cleanup
Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
Hadn’t expected the rename to be a substantive code refactor, but I really like the use of an accessor for this. Thanks for the change, it’s a big improvement.
[ Full content available at: https://github.com/apache/geode-native/pull/437 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on pull request #437:
GEODE-2484: Remove more ACE and cleanup
Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
Oh wait, is it Transaction State? Wow, how bad is this name?
[ Full content available at: https://github.com/apache/geode-native/pull/437 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#437: GEODE-2484: Remove more ACE and cleanup
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Yeah, it is a really bad name. Was keeping them consistent to avoid rebasing issues, but I can change it.
[ Full content available at: https://github.com/apache/geode-native/pull/437 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on pull request #437:
GEODE-2484: Remove more ACE and cleanup
Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
sigh. This is surely beyond the scope of this PR, but it would sure be nice if we could stomp out cryptic, meaningless variable names, esp if they happen to be using something ill-advised like a variant of Hungarian notation. A global search/replace to something like `geodeThreadLocalTransferState` would be amazing, even if nobody still fully understands what it's for...
[ Full content available at: https://github.com/apache/geode-native/pull/437 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett closed pull request #437:
GEODE-2484: Remove more ACE and cleanup
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-native/pull/437 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org