[GitHub] spark pull request: [SPARK-6735][YARN] Add window based executor f...

[aditanase <gi...@git.apache.org>]

Github user aditanase commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10241#discussion_r49322343
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
    @@ -84,7 +84,19 @@ private[yarn] class YarnAllocator(
       @volatile private var numExecutorsRunning = 0
       // Used to generate a unique ID per executor
       private var executorIdCounter = 0
    -  @volatile private var numExecutorsFailed = 0
    +
    +  // Queue to store the timestamp of failed executors
    +  private val failedExecutorsTimeStamps = new Queue[Long]()
    +
    +  private val clock = new SystemClock
    +
    +  private val executorFailuresValidityInterval = {
    +    if (sparkConf.contains("spark.yarn.executor.failuresValidityInterval")) {
    +      sparkConf.getTimeAsMs("spark.yarn.executor.failuresValidityInterval")
    --- End diff --
    
    What if the conversion breaks? Should this be wrapped in a Try?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org