[jira] [Commented] (OPENNLP-229) Write a test case for the NameFinderSequenceValidator class

["Joern Kottmann (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990991#comment-13990991 ] 

Joern Kottmann commented on OPENNLP-229:
----------------------------------------

I reviewed the code but then was interrupted by something. I think the code flow is hard to follow with the for loop.
Maybe it would be better to have a couple of test cases following each other. So it is clearer to see what is being done.

Anyway, let me have a second look and step through it with a debugger. Will very likely have more feedback then.

> Write a test case for the NameFinderSequenceValidator class
> -----------------------------------------------------------
>
>                 Key: OPENNLP-229
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-229
>             Project: OpenNLP
>          Issue Type: Task
>          Components: Name Finder
>            Reporter: Joern Kottmann
>            Priority: Minor
>         Attachments: OPENNLP-229.patch, OPENNLP-229.patch, patch_OPENNLP-229.java, patch_OPENNLP-229_added.patch
>
>
> The NameFinderSequenceValidator is public now, and that makes it possible to write a test for it. The test should check that the sequence validation works as expected.



--
This message was sent by Atlassian JIRA
(v6.2#6252)