You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/04/25 02:22:15 UTC

[GitHub] [cordova-android] breautek opened a new pull request #962: breaking: Bump android gradle plugin to 3.6.0

breautek opened a new pull request #962:
URL: https://github.com/apache/cordova-android/pull/962


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Upgrades android gradle plugin to 3.6.0.
   
   afaik there are no issues that are dependant on this change, but this is usually considered a breaking change, so it would be great to be included in the 9.0.0 release.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Updated the framework and the two android test projects version pins.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   ran `npm test`
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] breautek commented on pull request #962: breaking: Bump android gradle plugin to 3.6.0

Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #962:
URL: https://github.com/apache/cordova-android/pull/962#issuecomment-619687638


   I used https://developer.android.com/studio/releases/gradle-plugin to determine the latest, they don't mention 3.6.3 O.o


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] breautek edited a comment on pull request #962: breaking: Bump android gradle plugin to 3.6.0

Posted by GitBox <gi...@apache.org>.
breautek edited a comment on pull request #962:
URL: https://github.com/apache/cordova-android/pull/962#issuecomment-619687638


   I used https://developer.android.com/studio/releases/gradle-plugin to determine the latest, they don't mention 3.6.3 O.o
   
   3.6.x changes shouldn't be breaking anyway, so if we need it should be easy to update at anytime.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] erisu edited a comment on pull request #962: breaking: Bump android gradle plugin to 3.6.0

Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #962:
URL: https://github.com/apache/cordova-android/pull/962#issuecomment-619678064


   `3.6.3` I believe is actually the latest release from April.
   
   https://mvnrepository.com/artifact/com.android.tools.build/gradle/3.6.3


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] timbru31 commented on pull request #962: breaking: Bump android gradle plugin to 3.6.0

Posted by GitBox <gi...@apache.org>.
timbru31 commented on pull request #962:
URL: https://github.com/apache/cordova-android/pull/962#issuecomment-619362966


   Release Notes are over here: https://developer.android.com/studio/releases/gradle-plugin#3-6-0


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] erisu commented on pull request #962: breaking: Bump android gradle plugin to 3.6.0

Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #962:
URL: https://github.com/apache/cordova-android/pull/962#issuecomment-619678064


   `3.6.3` I believe is actually the latest release from April.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org