You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jena.apache.org by an...@apache.org on 2012/08/15 17:16:56 UTC
svn commit: r1373454 -
/jena/trunk/jena-arq/src/main/java/com/hp/hpl/jena/sparql/algebra/optimize/TransformFilterEquality.java
Author: andy
Date: Wed Aug 15 15:16:55 2012
New Revision: 1373454
URL: http://svn.apache.org/viewvc?rev=1373454&view=rev
Log:
Tidy up - no functional changes.
Modified:
jena/trunk/jena-arq/src/main/java/com/hp/hpl/jena/sparql/algebra/optimize/TransformFilterEquality.java
Modified: jena/trunk/jena-arq/src/main/java/com/hp/hpl/jena/sparql/algebra/optimize/TransformFilterEquality.java
URL: http://svn.apache.org/viewvc/jena/trunk/jena-arq/src/main/java/com/hp/hpl/jena/sparql/algebra/optimize/TransformFilterEquality.java?rev=1373454&r1=1373453&r2=1373454&view=diff
==============================================================================
--- jena/trunk/jena-arq/src/main/java/com/hp/hpl/jena/sparql/algebra/optimize/TransformFilterEquality.java (original)
+++ jena/trunk/jena-arq/src/main/java/com/hp/hpl/jena/sparql/algebra/optimize/TransformFilterEquality.java Wed Aug 15 15:16:55 2012
@@ -127,17 +127,11 @@ public class TransformFilterEquality ext
Op opLeft = opleftjoin.getLeft() ;
//Op opRight = opleftjoin.getRight() ;
- // ?? Slightly stronger condition than OpConditional transformation.
- // ** Extract out the (conditional) condition
- // ** Reorder so join optimization does first and be more aggregsssive if (conditional).
- // The requirment is that all expression vars are certainy bound.
-
+ // See also transform condition for OpConditional transformation.
+
Set<Var> varsLeft = OpVars.patternVars(opLeft) ;
//Set<Var> varsRight = OpVars.patternVars(opRight) ;
Set<Var> y = ExprVars.getVarsMentioned(exprs) ;
-
- //if ( varsLeft.containsAll(y) )
-
if ( varsLeft.containsAll(y) )
return true ;
return false ;
@@ -245,12 +239,12 @@ public class TransformFilterEquality ext
return OpAssign.assign(op, var, nv) ;
}
- private static Op subst(Op subOp , ExprVar var1, ExprVar var2)
- {
- // Replace var2 with var1
- Op op = Substitute.substitute(subOp, var2.asVar(), var1.asVar()) ;
- // Insert LET(var2 := var1)
- return OpAssign.assign(op, var2.asVar(), var1) ;
- }
+// private static Op subst(Op subOp , ExprVar var1, ExprVar var2)
+// {
+// // Replace var2 with var1
+// Op op = Substitute.substitute(subOp, var2.asVar(), var1.asVar()) ;
+// // Insert LET(var2 := var1)
+// return OpAssign.assign(op, var2.asVar(), var1) ;
+// }
}