Re: [PR] [SPARK-46875][SQL] When the `mode` is null, a `NullPointException` should `not` be thrown [spark]

["panbingkun (via GitHub)" <gi...@apache.org>]

panbingkun commented on code in PR #44900:
URL: https://github.com/apache/spark/pull/44900#discussion_r1467492531


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ParseMode.scala:
##########
@@ -47,12 +47,17 @@ object ParseMode extends Logging {
   /**
    * Returns the parse mode from the given string.
    */
-  def fromString(mode: String): ParseMode = mode.toUpperCase(Locale.ROOT) match {
-    case PermissiveMode.name => PermissiveMode
-    case DropMalformedMode.name => DropMalformedMode
-    case FailFastMode.name => FailFastMode
-    case _ =>
-      logWarning(s"$mode is not a valid parse mode. Using ${PermissiveMode.name}.")
-      PermissiveMode
+  def fromString(mode: String): ParseMode = Option(mode).map {
+    v => v.toUpperCase(Locale.ROOT) match {
+      case PermissiveMode.name => PermissiveMode
+      case DropMalformedMode.name => DropMalformedMode
+      case FailFastMode.name => FailFastMode
+      case _ =>
+        logWarning(s"$v is not a valid parse mode. Using ${PermissiveMode.name}.")
+        PermissiveMode
+    }
+  }.getOrElse {
+    logWarning(s"mode is null and not a valid parse mode. Using ${PermissiveMode.name}.")
+    PermissiveMode

Review Comment:
   @MaxGekk 
   In the current logic, when mode is null, the following error is displayed:
   <img width="1006" alt="image" src="https://github.com/apache/spark/assets/15246973/5b7ac743-62bc-4317-a172-6ce431920f34">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org