You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Mohammad Nour El-Din <no...@gmail.com> on 2007/11/07 11:46:39 UTC
Re: svn commit: r591858 [2/13] - in /openejb/trunk/openejb3: ./ assembly/openejb-tomcat/ assembly/openejb-tomcat/src/main/java/org/apache/openejb/tomcat/ container/openejb-core/ container/openejb-core/src/main/java/org/apache/openejb/ container/opene
This may not seem to be so related to this thread, but why we still care
about any of Geronimo code into our standalone version of OpenEJB3.0, can't
we mentain a code without any relation to Geronimo ???
On Nov 7, 2007 12:18 AM, Dain Sundstrom <da...@iq80.com> wrote:
> Injections and classloader are only used for webservice refs, and
> since G does it's own processing of webservice refs, you can pass in
> null or an empty list for injections. For the class loader, I'd pass
> in the correct module class loader.
>
> -dain
>
> On Nov 6, 2007, at 1:33 PM, Joe Bohn wrote:
>
> > I just checked in a change that gets things building again. It may
> > be totally incorrect so please make updates or revert as necessary.
> >
> > http://svn.apache.org/viewvc?view=rev&revision=592559
> >
> > Thanks,
> > Joe
> >
> >
> > David Blevins wrote:
> >> On Nov 6, 2007, at 8:14 AM, Joe Bohn wrote:
> >>> These changes in JndiEncBuilder require some comparable changes
> >>> in Geronimo's EjbRefBuidler. I don't really know the details of
> >>> the big change but Geronimo used construct a JndiEncBuilder using
> >>> just these two parameters:
> >>>
> >>> JndiEncBuilder jndiEncBuilder = new JndiEncBuilder(jndiEncInfo,
> >>> module.getName())
> >>>
> >>> It seems that the new constructor requires a list of injections
> >>> and a classloader. I presume something like this would work but
> >>> I'm not sure which classloader we need to pass. Any pointers?
> >>>
> >>> InjectionBuilder injectionBuilder = new
> >>> InjectionBuilder(classloader?);
> >>> List<Injection> injections =
> >>> injectionBuilder.buildInjections(jndiEncInfo);
> >>> JndiEncBuilder jndiEncBuilder = new JndiEncBuilder
> >>> (jndiEncInfo, injections, module.getTargetPath(), classloader?);
> >> Still looking through that change myself, so I'm not too sure.
> >> Gives me the idea that we should add a little javadoc "@geronimo
> >> EjbRefBuilder" note to the methods we had to expose to the
> >> Geronimo geronimo-openejb-builder module so it's easier to spot.
> >> -David
>
>
--
Thanks
- Mohammad Nour
Re: svn commit: r591858 [2/13] - in /openejb/trunk/openejb3: ./ assembly/openejb-tomcat/ assembly/openejb-tomcat/src/main/java/org/apache/openejb/tomcat/ container/openejb-core/ container/openejb-core/src/main/java/org/apache/openejb/ container/opene
Posted by David Blevins <da...@visi.com>.
On Nov 7, 2007, at 2:46 AM, Mohammad Nour El-Din wrote:
> This may not seem to be so related to this thread, but why we still
> care
> about any of Geronimo code into our standalone version of
> OpenEJB3.0, can't
> we mentain a code without any relation to Geronimo ???
In an ideal world our more solid public apis would be enough, but in
order to pull off some parts of the integration (mostly around naming)
we had to expose a few classes and methods that are not intended for
external consumption and change often.
-David
>
>
> On Nov 7, 2007 12:18 AM, Dain Sundstrom <da...@iq80.com> wrote:
>
>> Injections and classloader are only used for webservice refs, and
>> since G does it's own processing of webservice refs, you can pass in
>> null or an empty list for injections. For the class loader, I'd pass
>> in the correct module class loader.
>>
>> -dain
>>
>> On Nov 6, 2007, at 1:33 PM, Joe Bohn wrote:
>>
>>> I just checked in a change that gets things building again. It may
>>> be totally incorrect so please make updates or revert as necessary.
>>>
>>> http://svn.apache.org/viewvc?view=rev&revision=592559
>>>
>>> Thanks,
>>> Joe
>>>
>>>
>>> David Blevins wrote:
>>>> On Nov 6, 2007, at 8:14 AM, Joe Bohn wrote:
>>>>> These changes in JndiEncBuilder require some comparable changes
>>>>> in Geronimo's EjbRefBuidler. I don't really know the details of
>>>>> the big change but Geronimo used construct a JndiEncBuilder using
>>>>> just these two parameters:
>>>>>
>>>>> JndiEncBuilder jndiEncBuilder = new JndiEncBuilder(jndiEncInfo,
>>>>> module.getName())
>>>>>
>>>>> It seems that the new constructor requires a list of injections
>>>>> and a classloader. I presume something like this would work but
>>>>> I'm not sure which classloader we need to pass. Any pointers?
>>>>>
>>>>> InjectionBuilder injectionBuilder = new
>>>>> InjectionBuilder(classloader?);
>>>>> List<Injection> injections =
>>>>> injectionBuilder.buildInjections(jndiEncInfo);
>>>>> JndiEncBuilder jndiEncBuilder = new JndiEncBuilder
>>>>> (jndiEncInfo, injections, module.getTargetPath(), classloader?);
>>>> Still looking through that change myself, so I'm not too sure.
>>>> Gives me the idea that we should add a little javadoc "@geronimo
>>>> EjbRefBuilder" note to the methods we had to expose to the
>>>> Geronimo geronimo-openejb-builder module so it's easier to spot.
>>>> -David
>>
>>
>
>
> --
> Thanks
> - Mohammad Nour