Re: [PR] fix(chart): updates counties of kenya map [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #38019:
URL: https://github.com/apache/superset/pull/38019#issuecomment-4302876337

   Thanks for picking this up — the old map really was broken (per #34100), and aligning with ISO 3166-2:KE (`KE-01`…`KE-47`) is clearly the right direction.
   
   Two things I'd like to nail down before approving:
   
   1. **Data provenance / licensing.** The notebook reads from `https://raw.githubusercontent.com/drzackyll/kenya-counties/main/counties.geojson`, which is a personal repo. For an Apache release we should be sourcing the boundaries from an authoritative, clearly-licensed dataset (e.g. Kenya NBS, OCHA HDX, GADM, or Natural Earth if/when they update). Could you confirm the original provenance and license of that GeoJSON, and point the notebook at the upstream source directly? A short note in the notebook (or a README alongside it) citing the source and license would be ideal.
   
   2. **Breaking change heads-up.** This swaps the key space from the old province codes (`KE-110`, `KE-200`, …, `KE-800`) to the 47 county codes. Any dashboard currently joining on the old codes will break silently after upgrade. Would you mind adding a short entry to `UPDATING.md` under the next release so users know to re-key their Kenya data to ISO 3166-2:KE?
   
   Once those are addressed I'm happy to approve.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org