[jira] [Commented] (KAFKA-5469) Created state changelog topics not logged correctly

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053801#comment-16053801 ] 

ASF GitHub Bot commented on KAFKA-5469:
---------------------------------------

GitHub user ppatierno opened a pull request:

    https://github.com/apache/kafka/pull/3368

    KAFKA-5469: Created state changelog topics not logged correctly

    Fixed debug logging for the created state changelog topics
    Added toString() for InternalTopicMetadata and InternalTopicConfig for above debug logging

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ppatierno/kafka kafka-5469

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3368
    
----
commit 33d1ce3abdd99c98a8d878d266849347d1f20807
Author: ppatierno <pp...@live.com>
Date:   2017-06-19T10:56:35Z

    Fixed debug loggin for the created state changelog topics
    Added toString() for InternalTopicMetadata and InternalTopicConfig for above debug logging

----


> Created state changelog topics not logged correctly
> ---------------------------------------------------
>
>                 Key: KAFKA-5469
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5469
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: Paolo Patierno
>            Assignee: Paolo Patierno
>
> In the StreamPartitionAssignor class, the created state changelog topics aren't not logged correctly if the DEBUG log level is set.
> {code}
> [2017-06-19 12:18:44,186] DEBUG stream-thread [streams-temperature-6d25c7ff-0927-4469-8ab3-24444685e7d8-StreamThread-1] Created state changelog topics {streams-temperature-KSTREAM-REDUCE-STATE-STORE-0000000002-changelog=org.apache.kafka.streams.processor.internals.StreamPartitionAssignor$InternalTopicMetadata@65ae7693} from the parsed topology. (org.apache.kafka.streams.processor.internals.StreamPartitionAssignor:477)
> {code}
> against repartition topics which are well logged :
> {code}
> [2017-06-19 12:18:37,871] DEBUG stream-thread [streams-temperature-6d25c7ff-0927-4469-8ab3-24444685e7d8-StreamThread-1] Created repartition topics [Partition(topic = streams-temperature-KSTREAM-REDUCE-STATE-STORE-0000000002-repartition, partition = 0, leader = none, replicas = [], isr = [])] from the parsed topology. (org.apache.kafka.streams.processor.internals.StreamPartitionAssignor:402)
> {code}
> At same time if source topics are not created before launching the stream application, the state changelog topics log shows just {} (the placeholder) while for repartition topics the [] that is right because it's an empty list.
> It seems that there are two problems. For state changelog topics the values() is not used but then InternalTopicMetadata hasn't a toString() for having a well formatted output.
> I'm already working on that ..



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)