You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/04 15:10:31 UTC

[GitHub] [airflow] jstern commented on a change in pull request #7133: [AIRFLOW-6535] add exception to fail without retry

jstern commented on a change in pull request #7133: [AIRFLOW-6535] add exception to fail without retry
URL: https://github.com/apache/airflow/pull/7133#discussion_r374728286
 
 

 ##########
 File path: airflow/models/taskinstance.py
 ##########
 @@ -1124,64 +1129,56 @@ def handle_failure(self, error, test_mode=None, context=None, session=None):
         if context is not None:
             context['exception'] = error
 
-        # Let's go deeper
-        try:
 
 Review comment:
   the try/excepts have been tightened in scope to only be around the conditions they are logging and moving on from. see my response to your question about the start/end dates in the tests for more color on that

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services