You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/27 18:05:08 UTC
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1181: WIP Support NULL literals in Binary expressions, add some missing LargeStringArray implementations
alamb commented on a change in pull request #1181:
URL: https://github.com/apache/arrow-datafusion/pull/1181#discussion_r737722425
##########
File path: datafusion/src/physical_plan/expressions/binary.rs
##########
@@ -1477,6 +1548,213 @@ mod tests {
}
}
+ #[test]
+ fn test_compare_to_null_literal() {
Review comment:
This test found lots of good stuff -- I would say it is the best part of this PR at the moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org