You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/01 12:23:38 UTC

[GitHub] [kafka] KahnCheny opened a new pull request #10801: MINOR: remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface

KahnCheny opened a new pull request #10801:
URL: https://github.com/apache/kafka/pull/10801


   remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] KahnCheny commented on pull request #10801: MINOR: remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface

Posted by GitBox <gi...@apache.org>.
KahnCheny commented on pull request #10801:
URL: https://github.com/apache/kafka/pull/10801#issuecomment-852674851


   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #10801: MINOR: remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10801:
URL: https://github.com/apache/kafka/pull/10801#issuecomment-852816990


   @tombentley @chia7712 , could you help review this PR? I've reviewed and looks good. Need your 2nd review. Thank you.
    
   Failed tests are flaky tests.
   ```
       Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
       Build / JDK 8 and Scala 2.12 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions()
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] KahnCheny commented on pull request #10801: MINOR: remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface

Posted by GitBox <gi...@apache.org>.
KahnCheny commented on pull request #10801:
URL: https://github.com/apache/kafka/pull/10801#issuecomment-852667550


   @showuon Could you code review again？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac merged pull request #10801: MINOR: remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface

Posted by GitBox <gi...@apache.org>.
dajac merged pull request #10801:
URL: https://github.com/apache/kafka/pull/10801


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org