You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Ken Howe <kh...@pivotal.io> on 2016/09/19 19:12:06 UTC
Review Request 52052: GEODE-1128: Enhance missing-disk-stores command
with missing regions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52052/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, Scott Jewell, Swapnil Bawaskar, and Dan Smith.
Repository: geode
Description
-------
Refactored \u201cshow missing-disk-stores command\u201d and added a section to the
output to show missing colocated regions. Corrected messages in
LocalizedStrings, change \u201cgemfire list-missing-disk-stores\u201d to
\u201cgfsh show missing-disk-stores\u201d. Added new command function class to gather
both missing disk-store and missing colocated region information on a
distributed system member.
Parameterized show missing-disk-store error message.
Added new DataSerializable class for sending missing colocated region
results to gfsh command.
Refactored ColocationLogger. Class originally deferred updating the list
of missing colocated children (i.e. removing regions from the missing
list that are now present) for a region until the next logging
interval. This has been changed to update the list on-demand, whenever
getMissingChildRegions() is called.
Added DUnit test for new functionality in show missing-disk-store
command.
Added JUnit tests for new classes
New command oputput formats:
When there are no problems to report --
No missing disk store found
No missing colocated region found
Missing disk-stores (no missing colocated regions)
Missing Disk Stores
Disk Store ID | Host | Directory
------------------------------------ | -------------- | ---------------------------------
8c204b3a-47ca-4bf4-ab3d-e6f704ea6ac6 | /10.118.33.251 | /vm1/DiskStoreCommandsDUnitTest1
No missing colocated region found
Missing colocated regions (no missing disk-stores) --
No missing disk store found
Missing Colocated Regions
Host | Distributed Member | Parent Region | Missing Colocated Region
------------- | ------------------ | ----------------------------------------- | ------------------------
10.118.33.251 | Manager | /testShowPersistentRecoveryFailuresRegion | /childRegion
10.118.33.251 | VM1 | /testShowPersistentRecoveryFailuresRegion | /childRegion
Missing disk-stores and missing colocated regions -
Missing Disk Stores
Disk Store ID | Host | Directory
------------------------------------ | -------------- | ---------------------------------
09055140-cc35-48e1-a53a-91c0f5eb6644 | /10.118.33.251 | /vm1/DiskStoreCommandsDUnitTest1
Missing Colocated Regions
Host | Distributed Member | Parent Region | Missing Colocated Region
------------- | ------------------ | ----------------------------------------- | ------------------------
10.118.33.251 | VM1 | /testShowPersistentRecoveryFailuresRegion | /childRegion
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/ColocationLogger.java 0a3754763062c8f72b776085533bc1aeae87064b
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ColocatedRegionDetails.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java b61201ef60b4dc3ea6d42e7ae30d305e2ebb7e35
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 53f910854ab3e929821d19a27b74f5e6fb6d7ecc
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ShowMissingDiskStoresFunction.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java 1f0420b5eab16208135da47d862dfec3048f5548
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/ColocatedRegionDetailsJUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 9926ae67aedb4a520d4875e180b3408b35387bcd
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ShowMissingDiskStoresFunctionJUnitTest.java PRE-CREATION
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt 2240daf7ccc5b2283633687220776e5894c7235c
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 58b43955c61b2abdeb6e3c3aac11f6ab568a7d55
Diff: https://reviews.apache.org/r/52052/diff/
Testing
-------
precheckin
Thanks,
Ken Howe
Re: Review Request 52052: GEODE-1128: Enhance missing-disk-stores
command with missing regions
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52052/#review149762
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Sept. 19, 2016, 12:12 p.m., Ken Howe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52052/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2016, 12:12 p.m.)
>
>
> Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, Scott Jewell, Swapnil Bawaskar, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Refactored \u201cshow missing-disk-stores command\u201d and added a section to the
> output to show missing colocated regions. Corrected messages in
> LocalizedStrings, change \u201cgemfire list-missing-disk-stores\u201d to
> \u201cgfsh show missing-disk-stores\u201d. Added new command function class to gather
> both missing disk-store and missing colocated region information on a
> distributed system member.
>
> Parameterized show missing-disk-store error message.
>
> Added new DataSerializable class for sending missing colocated region
> results to gfsh command.
>
> Refactored ColocationLogger. Class originally deferred updating the list
> of missing colocated children (i.e. removing regions from the missing
> list that are now present) for a region until the next logging
> interval. This has been changed to update the list on-demand, whenever
> getMissingChildRegions() is called.
>
> Added DUnit test for new functionality in show missing-disk-store
> command.
>
> Added JUnit tests for new classes
>
> New command oputput formats:
>
> When there are no problems to report --
>
> No missing disk store found
> No missing colocated region found
>
>
> Missing disk-stores (no missing colocated regions)
>
> Missing Disk Stores
> Disk Store ID | Host | Directory
> ------------------------------------ | -------------- | ---------------------------------
> 8c204b3a-47ca-4bf4-ab3d-e6f704ea6ac6 | /10.118.33.251 | /vm1/DiskStoreCommandsDUnitTest1
>
> No missing colocated region found
>
>
> Missing colocated regions (no missing disk-stores) --
>
> No missing disk store found
>
> Missing Colocated Regions
> Host | Distributed Member | Parent Region | Missing Colocated Region
> ------------- | ------------------ | ----------------------------------------- | ------------------------
> 10.118.33.251 | Manager | /testShowPersistentRecoveryFailuresRegion | /childRegion
> 10.118.33.251 | VM1 | /testShowPersistentRecoveryFailuresRegion | /childRegion
>
>
> Missing disk-stores and missing colocated regions -
>
> Missing Disk Stores
> Disk Store ID | Host | Directory
> ------------------------------------ | -------------- | ---------------------------------
> 09055140-cc35-48e1-a53a-91c0f5eb6644 | /10.118.33.251 | /vm1/DiskStoreCommandsDUnitTest1
>
> Missing Colocated Regions
> Host | Distributed Member | Parent Region | Missing Colocated Region
> ------------- | ------------------ | ----------------------------------------- | ------------------------
> 10.118.33.251 | VM1 | /testShowPersistentRecoveryFailuresRegion | /childRegion
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/ColocationLogger.java 0a3754763062c8f72b776085533bc1aeae87064b
> geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ColocatedRegionDetails.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java b61201ef60b4dc3ea6d42e7ae30d305e2ebb7e35
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 53f910854ab3e929821d19a27b74f5e6fb6d7ecc
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ShowMissingDiskStoresFunction.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java 1f0420b5eab16208135da47d862dfec3048f5548
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/ColocatedRegionDetailsJUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 9926ae67aedb4a520d4875e180b3408b35387bcd
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ShowMissingDiskStoresFunctionJUnitTest.java PRE-CREATION
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt 2240daf7ccc5b2283633687220776e5894c7235c
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 58b43955c61b2abdeb6e3c3aac11f6ab568a7d55
>
> Diff: https://reviews.apache.org/r/52052/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Ken Howe
>
>
Re: Review Request 52052: GEODE-1128: Enhance missing-disk-stores
command with missing regions
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52052/#review149759
-----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/ColocationLogger.java (line 149)
<https://reviews.apache.org/r/52052/#comment217462>
should this be renamed to "updateAndGet..."?
- Darrel Schneider
On Sept. 19, 2016, 12:12 p.m., Ken Howe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52052/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2016, 12:12 p.m.)
>
>
> Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, Scott Jewell, Swapnil Bawaskar, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Refactored \u201cshow missing-disk-stores command\u201d and added a section to the
> output to show missing colocated regions. Corrected messages in
> LocalizedStrings, change \u201cgemfire list-missing-disk-stores\u201d to
> \u201cgfsh show missing-disk-stores\u201d. Added new command function class to gather
> both missing disk-store and missing colocated region information on a
> distributed system member.
>
> Parameterized show missing-disk-store error message.
>
> Added new DataSerializable class for sending missing colocated region
> results to gfsh command.
>
> Refactored ColocationLogger. Class originally deferred updating the list
> of missing colocated children (i.e. removing regions from the missing
> list that are now present) for a region until the next logging
> interval. This has been changed to update the list on-demand, whenever
> getMissingChildRegions() is called.
>
> Added DUnit test for new functionality in show missing-disk-store
> command.
>
> Added JUnit tests for new classes
>
> New command oputput formats:
>
> When there are no problems to report --
>
> No missing disk store found
> No missing colocated region found
>
>
> Missing disk-stores (no missing colocated regions)
>
> Missing Disk Stores
> Disk Store ID | Host | Directory
> ------------------------------------ | -------------- | ---------------------------------
> 8c204b3a-47ca-4bf4-ab3d-e6f704ea6ac6 | /10.118.33.251 | /vm1/DiskStoreCommandsDUnitTest1
>
> No missing colocated region found
>
>
> Missing colocated regions (no missing disk-stores) --
>
> No missing disk store found
>
> Missing Colocated Regions
> Host | Distributed Member | Parent Region | Missing Colocated Region
> ------------- | ------------------ | ----------------------------------------- | ------------------------
> 10.118.33.251 | Manager | /testShowPersistentRecoveryFailuresRegion | /childRegion
> 10.118.33.251 | VM1 | /testShowPersistentRecoveryFailuresRegion | /childRegion
>
>
> Missing disk-stores and missing colocated regions -
>
> Missing Disk Stores
> Disk Store ID | Host | Directory
> ------------------------------------ | -------------- | ---------------------------------
> 09055140-cc35-48e1-a53a-91c0f5eb6644 | /10.118.33.251 | /vm1/DiskStoreCommandsDUnitTest1
>
> Missing Colocated Regions
> Host | Distributed Member | Parent Region | Missing Colocated Region
> ------------- | ------------------ | ----------------------------------------- | ------------------------
> 10.118.33.251 | VM1 | /testShowPersistentRecoveryFailuresRegion | /childRegion
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/ColocationLogger.java 0a3754763062c8f72b776085533bc1aeae87064b
> geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/ColocatedRegionDetails.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java b61201ef60b4dc3ea6d42e7ae30d305e2ebb7e35
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 53f910854ab3e929821d19a27b74f5e6fb6d7ecc
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ShowMissingDiskStoresFunction.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java 1f0420b5eab16208135da47d862dfec3048f5548
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/ColocatedRegionDetailsJUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 9926ae67aedb4a520d4875e180b3408b35387bcd
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ShowMissingDiskStoresFunctionJUnitTest.java PRE-CREATION
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt 2240daf7ccc5b2283633687220776e5894c7235c
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 58b43955c61b2abdeb6e3c3aac11f6ab568a7d55
>
> Diff: https://reviews.apache.org/r/52052/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Ken Howe
>
>