You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/21 10:22:21 UTC
[GitHub] [flink] MartijnVisser opened a new pull request, #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive
MartijnVisser opened a new pull request, #21542:
URL: https://github.com/apache/flink/pull/21542
## What is the purpose of the change
* Exclude `org.pentaho:pentaho-aggdesigner-algorithm` from the Hive dependencies to avoid users with newer Maven versions having issues to build Flink locally.
## Brief change log
* Excluded `org.pentaho:pentaho-aggdesigner-algorithm` in Hive connector pom.xml
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive
Posted by GitBox <gi...@apache.org>.
rmetzger commented on PR #21542:
URL: https://github.com/apache/flink/pull/21542#issuecomment-1362908054
@MartijnVisser I hope its fine that I asked @gunnarmorling to take a look at this change :)
+1 to wait until we know that Hive still works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21542:
URL: https://github.com/apache/flink/pull/21542#issuecomment-1362556563
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21542:
URL: https://github.com/apache/flink/pull/21542#issuecomment-1377887404
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #21542:
URL: https://github.com/apache/flink/pull/21542#issuecomment-1364921704
> Theses change looks good to me. I perfer to find some times to verify it will still work in my hive test env.
I'm back. I have verified with Hive 2.3.9 & Hive 3.1.3, it still works after we exclude pentaho dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21542:
URL: https://github.com/apache/flink/pull/21542#issuecomment-1361132914
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e1f02d10c39252c23b8f6e1b0fa8a0ac664f8852",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e1f02d10c39252c23b8f6e1b0fa8a0ac664f8852",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e1f02d10c39252c23b8f6e1b0fa8a0ac664f8852 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a diff in pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #21542:
URL: https://github.com/apache/flink/pull/21542#discussion_r1054221525
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -862,10 +866,6 @@ under the License.
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</exclusion>
- <exclusion>
- <groupId>org.pentaho</groupId>
- <artifactId>pentaho-aggdesigner-algorithm</artifactId>
- </exclusion>
Review Comment:
While it was excluded here, there is no Pentaho included in `hive-webhcat-java-client` according to the dependency tree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #21542:
URL: https://github.com/apache/flink/pull/21542#issuecomment-1362654931
Theses change looks good to me. I perfer to find some times to verify it will still work in my hive test env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #21542:
URL: https://github.com/apache/flink/pull/21542#issuecomment-1362955370
`mvn dependency:tree` tells that there is another dependency on `org.pentaho:pentaho-aggdesigner-algorithm` in `flink-sql-client`
shouldn't it also be excluded there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21542:
URL: https://github.com/apache/flink/pull/21542#issuecomment-1362682534
> Theses change looks good to me. I perfer to find some times to verify it will still work in my hive test env.
Let's leave it open until you have been able to verify it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive
Posted by GitBox <gi...@apache.org>.
rmetzger commented on PR #21542:
URL: https://github.com/apache/flink/pull/21542#issuecomment-1378706979
Looks like the CI failure is a known issue: https://issues.apache.org/jira/browse/FLINK-29427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21542:
URL: https://github.com/apache/flink/pull/21542#issuecomment-1361129709
@luoyuxia Let me know what you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21542:
URL: https://github.com/apache/flink/pull/21542#issuecomment-1362681986
> Hey @MartijnVisser, thanks for opening this PR. Stumbled upon this very same issue [just recently](https://www.morling.dev/blog/maven-what-are-you-waiting-for/). I can confirm that the dependency is not part of the tree any longer as per your change; are we sure though it's really not needed by Hive? If we are, then this LGTM.
Prior to opening the PR I've asked one of our Hive connector maintainers @luoyuxia if it's needed by Hive. From what I could find Pentaho is rather old report creation tool; Flink definitely doesn't do anything with it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21542:
URL: https://github.com/apache/flink/pull/21542#issuecomment-1373827479
> @MartijnVisser I hope its fine that I asked @gunnarmorling to take a look at this change :)
> +1 to wait until we know that Hive still works.
@rmetzger If you can have another look, I can finish this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser merged pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive
Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #21542:
URL: https://github.com/apache/flink/pull/21542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21542:
URL: https://github.com/apache/flink/pull/21542#issuecomment-1365743830
> I'm back. I have verified with Hive 2.3.9 & Hive 3.1.3, it still works after we exclude pentaho dependency.
Thanks for checking!
> `mvn dependency:tree` tells that there is another dependency on `org.pentaho:pentaho-aggdesigner-algorithm` in `flink-sql-client`
> shouldn't it also be excluded there?
Yes we should. I'll update the PR to include that, thanks for double checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org