You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jonathan Gray (JIRA)" <ji...@apache.org> on 2009/09/11 04:51:57 UTC

[jira] Created: (HBASE-1827) Add disabling block cache scanner flag to the shell, option for scan and count

Add disabling block cache scanner flag to the shell, option for scan and count
------------------------------------------------------------------------------

                 Key: HBASE-1827
                 URL: https://issues.apache.org/jira/browse/HBASE-1827
             Project: Hadoop HBase
          Issue Type: Improvement
          Components: scripts
    Affects Versions: 0.20.0
            Reporter: Jonathan Gray
             Fix For: 0.20.1, 0.21.0


HBASE-1823 added an option for individual Scans to not cache blocks.  Expose this as an option in the shell for scan and count.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1827) Add disabling block cache scanner flag to the shell, option for scan and count

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754281#action_12754281 ] 

stack commented on HBASE-1827:
------------------------------

Depends on HBASE-1823.  When this is in place, this patch works.  +1 on commit (after hbase-1823)

> Add disabling block cache scanner flag to the shell, option for scan and count
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-1827
>                 URL: https://issues.apache.org/jira/browse/HBASE-1827
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: HBASE-1827.patch
>
>
> HBASE-1823 added an option for individual Scans to not cache blocks.  Expose this as an option in the shell for scan and count.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HBASE-1827) Add disabling block cache scanner flag to the shell, option for scan and count

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell reassigned HBASE-1827:
-------------------------------------

    Assignee: Andrew Purtell

> Add disabling block cache scanner flag to the shell, option for scan and count
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-1827
>                 URL: https://issues.apache.org/jira/browse/HBASE-1827
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Andrew Purtell
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: HBASE-1827.patch
>
>
> HBASE-1823 added an option for individual Scans to not cache blocks.  Expose this as an option in the shell for scan and count.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1827) Add disabling block cache scanner flag to the shell, option for scan and count

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754412#action_12754412 ] 

stack commented on HBASE-1827:
------------------------------

I just figured that the group of those senstive to blowing cache with a count from shell was small... and that they'd have their own means for exploiting the newly added API.

Go ahead then if you think it important or useful for 0.20.1.

> Add disabling block cache scanner flag to the shell, option for scan and count
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-1827
>                 URL: https://issues.apache.org/jira/browse/HBASE-1827
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: HBASE-1827.patch
>
>
> HBASE-1823 added an option for individual Scans to not cache blocks.  Expose this as an option in the shell for scan and count.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1827) Add disabling block cache scanner flag to the shell, option for scan and count

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754395#action_12754395 ] 

Jonathan Gray commented on HBASE-1827:
--------------------------------------

What do you guys think about disabling block caching by default on count?

> Add disabling block cache scanner flag to the shell, option for scan and count
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-1827
>                 URL: https://issues.apache.org/jira/browse/HBASE-1827
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: HBASE-1827.patch
>
>
> HBASE-1823 added an option for individual Scans to not cache blocks.  Expose this as an option in the shell for scan and count.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1827) Add disabling block cache scanner flag to the shell, option for scan and count

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell updated HBASE-1827:
----------------------------------

    Attachment: HBASE-1827.patch

> Add disabling block cache scanner flag to the shell, option for scan and count
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-1827
>                 URL: https://issues.apache.org/jira/browse/HBASE-1827
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: HBASE-1827.patch
>
>
> HBASE-1823 added an option for individual Scans to not cache blocks.  Expose this as an option in the shell for scan and count.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1827) Add disabling block cache scanner flag to the shell, option for scan and count

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell updated HBASE-1827:
----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Committed to branch and trunk. Also fixed a bug where 'scan' and 'count' would return two different row counts for the same amount of work. 'count' had it right. 

> Add disabling block cache scanner flag to the shell, option for scan and count
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-1827
>                 URL: https://issues.apache.org/jira/browse/HBASE-1827
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Andrew Purtell
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: HBASE-1827.patch
>
>
> HBASE-1823 added an option for individual Scans to not cache blocks.  Expose this as an option in the shell for scan and count.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1827) Add disabling block cache scanner flag to the shell, option for scan and count

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell updated HBASE-1827:
----------------------------------

    Status: Patch Available  (was: Open)

> Add disabling block cache scanner flag to the shell, option for scan and count
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-1827
>                 URL: https://issues.apache.org/jira/browse/HBASE-1827
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: HBASE-1827.patch
>
>
> HBASE-1823 added an option for individual Scans to not cache blocks.  Expose this as an option in the shell for scan and count.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1827) Add disabling block cache scanner flag to the shell, option for scan and count

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754278#action_12754278 ] 

stack commented on HBASE-1827:
------------------------------

Patch looks good.  It applied for me.  When I went to use it, it seems it depends on another being present:

{code}
hbase(main):005:0> scan '.META.', {CACHE_BLOCKS => false}
NoMethodError: undefined method `setCacheBlocks' for #<Java::OrgApacheHadoopHbaseClient::Scan:0x94b318>
	from /home/stack/checkouts/workspace/svn_hbase_trunk/bin/../bin/hirb.rb:398:in `scan'
	from (hbase):6:in `irb_binding'
{code}

> Add disabling block cache scanner flag to the shell, option for scan and count
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-1827
>                 URL: https://issues.apache.org/jira/browse/HBASE-1827
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: HBASE-1827.patch
>
>
> HBASE-1823 added an option for individual Scans to not cache blocks.  Expose this as an option in the shell for scan and count.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1827) Add disabling block cache scanner flag to the shell, option for scan and count

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754399#action_12754399 ] 

stack commented on HBASE-1827:
------------------------------

You could but who seriously does a 'count' from the shell?  Better to disable it in RowCounter?

> Add disabling block cache scanner flag to the shell, option for scan and count
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-1827
>                 URL: https://issues.apache.org/jira/browse/HBASE-1827
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: HBASE-1827.patch
>
>
> HBASE-1823 added an option for individual Scans to not cache blocks.  Expose this as an option in the shell for scan and count.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1827) Add disabling block cache scanner flag to the shell, option for scan and count

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754400#action_12754400 ] 

stack commented on HBASE-1827:
------------------------------

I'd do it as separate issue?  Should it be in 0.20.1?  I don't think so.

> Add disabling block cache scanner flag to the shell, option for scan and count
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-1827
>                 URL: https://issues.apache.org/jira/browse/HBASE-1827
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: HBASE-1827.patch
>
>
> HBASE-1823 added an option for individual Scans to not cache blocks.  Expose this as an option in the shell for scan and count.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1827) Add disabling block cache scanner flag to the shell, option for scan and count

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754405#action_12754405 ] 

Jonathan Gray commented on HBASE-1827:
--------------------------------------

Huh?  I count from the shell all the time, obviously not on big tables.  Why would all this go into 0.20.1 but adding it to count/rowcounter wouldn't?  They are simpler changes.

> Add disabling block cache scanner flag to the shell, option for scan and count
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-1827
>                 URL: https://issues.apache.org/jira/browse/HBASE-1827
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: HBASE-1827.patch
>
>
> HBASE-1823 added an option for individual Scans to not cache blocks.  Expose this as an option in the shell for scan and count.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1827) Add disabling block cache scanner flag to the shell, option for scan and count

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754431#action_12754431 ] 

Andrew Purtell commented on HBASE-1827:
---------------------------------------

Users may invoke count. Seems like a smart low impact thing to do to disable caching when doing so.

> Add disabling block cache scanner flag to the shell, option for scan and count
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-1827
>                 URL: https://issues.apache.org/jira/browse/HBASE-1827
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: HBASE-1827.patch
>
>
> HBASE-1823 added an option for individual Scans to not cache blocks.  Expose this as an option in the shell for scan and count.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.