You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by grkvlt <gi...@git.apache.org> on 2016/08/31 00:27:15 UTC
[GitHub] brooklyn-server pull request #313: Adds deprecated decorate method to preser...
GitHub user grkvlt opened a pull request:
https://github.com/apache/brooklyn-server/pull/313
Adds deprecated decorate method to preserve backwards compatibility
Adds `#decorate(EntitySpec<?>, ConfigBag)` as an overloaded deprecated method in `BrooklynEntityDecorationResolver` interface, for backwards compatibility.
See https://github.com/cloudsoft/brooklyn-tosca/pull/113
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/grkvlt/brooklyn-server add-deprecated-decorate-method
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #313
----
commit 886538cfe97fe3534d754714f7127724787ee6ee
Author: Andrew Donald Kennedy <an...@cloudsoftcorp.com>
Date: 2016-08-31T00:25:09Z
Adds deprecated decorate method to preserve backwards compatibility with BrooklynEntityDecorationResolver
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #313: Adds deprecated decorate method to preser...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/313
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #313: Adds deprecated decorate method to preser...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/313#discussion_r76905392
--- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java ---
@@ -46,22 +46,26 @@
/**
* Pattern for resolving "decorations" on service specs / entity specs, such as policies, enrichers, etc.
+ *
* @since 0.7.0
*/
-@Beta
public abstract class BrooklynEntityDecorationResolver<DT> {
public final BrooklynYamlTypeInstantiator.Factory instantiator;
-
+
protected BrooklynEntityDecorationResolver(BrooklynYamlTypeInstantiator.Factory instantiator) {
this.instantiator = instantiator;
}
-
+
+ /** @deprected since 0.10.0 - use {@link #decorate(EntitySpec<?>, ConfigBag, Set<String>)} */
+ @Deprecated
+ public abstract void decorate(EntitySpec<?> entitySpec, ConfigBag attrs);
--- End diff --
make this `public final` not abstract with the implementation passing the empty `ImmutableSet` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #313: Adds deprecated decorate method to preserve back...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/313
one tweak then good to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #313: Adds deprecated decorate method to preser...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/313#discussion_r76905405
--- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java ---
@@ -46,22 +46,26 @@
/**
* Pattern for resolving "decorations" on service specs / entity specs, such as policies, enrichers, etc.
+ *
* @since 0.7.0
*/
-@Beta
--- End diff --
agree
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---