You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/08/21 14:06:08 UTC

[GitHub] [mynewt-core] kasjer opened a new pull request #2671: apps/sensors_test: Remove blinking tasks

kasjer opened a new pull request #2671:
URL: https://github.com/apache/mynewt-core/pull/2671


   Application defined 2 tasks to blink 1 led.
   It also provided default pin (15) for led if
   BSP did not provide LED_BLINK_PIN definition.
   
   Amount of RAM used for tasks and stacks prevents
   this application to run on MCUs with 20KB of RAM.
   
   This:
   - replaces tasks with callout reducing RAM used.
   - removes local hard coded definition of LED,
     so pin 15 may be used for something else.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] vrahane commented on pull request #2671: apps/sensors_test: Remove blinking tasks

Posted by GitBox <gi...@apache.org>.

vrahane commented on pull request #2671:
URL: https://github.com/apache/mynewt-core/pull/2671#issuecomment-903205152


   Yes, that is correct. It was meant to be same as slinky so that other devs could pick it up quite easily. I do agree, reducing the memory usage does make sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] kasjer merged pull request #2671: apps/sensors_test: Remove blinking tasks

Posted by GitBox <gi...@apache.org>.

kasjer merged pull request #2671:
URL: https://github.com/apache/mynewt-core/pull/2671


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] utzig commented on pull request #2671: apps/sensors_test: Remove blinking tasks

Posted by GitBox <gi...@apache.org>.

utzig commented on pull request #2671:
URL: https://github.com/apache/mynewt-core/pull/2671#issuecomment-903172119


   Looks like it copied the blinking code from slinky.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org