You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "David Martin (Jira)" <ji...@apache.org> on 2021/03/29 18:05:00 UTC
[jira] [Comment Edited] (QPIDJMS-530) Potential NPE in JmsSession
consumerClosed()
[ https://issues.apache.org/jira/browse/QPIDJMS-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310800#comment-17310800 ]
David Martin edited comment on QPIDJMS-530 at 3/29/21, 6:04 PM:
----------------------------------------------------------------
Thank you [~tabish] Surprisingly seems to have broken a test though.
was (Author: indysilver):
Thank you [~tabish] (I think I can use the 529 fix too)
> Potential NPE in JmsSession consumerClosed()
> --------------------------------------------
>
> Key: QPIDJMS-530
> URL: https://issues.apache.org/jira/browse/QPIDJMS-530
> Project: Qpid JMS
> Issue Type: Bug
> Affects Versions: 0.56.0
> Reporter: David Martin
> Assignee: Timothy A. Bish
> Priority: Major
> Fix For: 0.58.0
>
>
> In the following code (JMSSession line 416), if consumer is null this throws a NPE and the consumer never recovers:
> {noformat}
> JmsMessageConsumer consumer = consumers.get(resource.getId());
> if (consumer.hasMessageListener()) {
> connection.onAsyncException(JmsExceptionSupport.create(cause));
> }
> try {
> if (consumer != null) {
> consumer.shutdown(cause);
> }
> {noformat}
> Happy to raise a PR myself for this (just ask) but I have had to fix it locally.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org