[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8858: Fix getConfigOverrides in MinionQuickstart

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #8858:
URL: https://github.com/apache/pinot/pull/8858#discussion_r892897555


##########
pinot-tools/src/main/java/org/apache/pinot/tools/RealtimeQuickStartWithMinion.java:
##########
@@ -63,7 +64,7 @@ public static void main(String[] args)
   }
 
   public Map<String, Object> getConfigOverrides() {
-    Map<String, Object> properties = super.getConfigOverrides();
+    Map<String, Object> properties = new HashMap<>();

Review Comment:
   Suggest fixing the super class to create an empty hash map instead. We want to keep the configs from the base class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org