You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/01/15 14:10:30 UTC
[GitHub] [logging-log4j2] ChristophKaser opened a new pull request #332:
LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and
HtmlLayout
ChristophKaser opened a new pull request #332: LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout
URL: https://github.com/apache/logging-log4j2/pull/332
This PR consist of a regression test showcasing the problem(s) and a fix.
See https://issues.apache.org/jira/browse/LOG4J2-2760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] rgoers commented on a change in pull request #332:
LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and
HtmlLayout
Posted by GitBox <gi...@apache.org>.
rgoers commented on a change in pull request #332: LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout
URL: https://github.com/apache/logging-log4j2/pull/332#discussion_r376753729
##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/OutputStreamManager.java
##########
@@ -164,6 +164,7 @@ public boolean hasOutputStream() {
protected OutputStream getOutputStream() throws IOException {
if (outputStream == null) {
outputStream = createOutputStream();
+ setOutputStream(outputStream); // Needed so the header will be written
Review comment:
It seems like this should be
```
if (outputSteam == null) {
setOutputStream(createOutputStream);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] rgoers merged pull request #332: LOG4J2-2760:
Fixes RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout
Posted by GitBox <gi...@apache.org>.
rgoers merged pull request #332: LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout
URL: https://github.com/apache/logging-log4j2/pull/332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] rgoers commented on a change in pull request #332:
LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and
HtmlLayout
Posted by GitBox <gi...@apache.org>.
rgoers commented on a change in pull request #332: LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout
URL: https://github.com/apache/logging-log4j2/pull/332#discussion_r376753729
##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/OutputStreamManager.java
##########
@@ -164,6 +164,7 @@ public boolean hasOutputStream() {
protected OutputStream getOutputStream() throws IOException {
if (outputStream == null) {
outputStream = createOutputStream();
+ setOutputStream(outputStream); // Needed so the header will be written
Review comment:
It seems like this should be
```
if (outputSteam == null) {
setOutputStream(createOutputStream);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services