You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/02/18 12:46:17 UTC
[GitHub] [fineract] francisguchie opened a new pull request #1627: Fineract 1070blasanhelpsguchie
francisguchie opened a new pull request #1627:
URL: https://github.com/apache/fineract/pull/1627
## Description
Describe the changes made and why they were made.
look at #1597
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1627: Fineract 1070blasanhelpsguchie
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1627:
URL: https://github.com/apache/fineract/pull/1627#issuecomment-781970550
The suggestions and approach to this in issue No. #1597 are far better than excluding the duplicate class path as used in this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie closed pull request #1627: Fineract 1070blasanhelpsguchie
Posted by GitBox <gi...@apache.org>.
francisguchie closed pull request #1627:
URL: https://github.com/apache/fineract/pull/1627
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org