You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Madhuka <gi...@git.apache.org> on 2015/08/11 17:04:24 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-217 : Adding documentati...
GitHub user Madhuka opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/203
ZEPPELIN-217 : Adding documentation on adding new chart types and Data validation serivce
Documentation on
- [x] How to add new chart libraries for zeppelin
- [x] How add new data validation schema
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Madhuka/incubator-zeppelin gh-pages
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/203.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #203
----
commit 00464b69e79556076bee466a9472ca7364fc1afc
Author: madhuka <ma...@gmail.com>
Date: 2015-08-11T11:25:06Z
adding docs
commit 71854522e30282a498b16d49115efc7a7de966d2
Author: madhuka <ma...@gmail.com>
Date: 2015-08-11T14:18:02Z
adding manual
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-217 : Adding documentati...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/203#issuecomment-131666450
The Data Validation documentation is too complicated and not complete I think.
I think the description should be reworked to emphasized where it is used in Zeppelin and for what purpose.
There should also have a part explaining exactly what it is doing (How the validation is done).
Some link to example, and/or an use case explanation.
Also the part about ``beyond data type validation`` is pretty obscure, it should be made so its easier to understand and apply. If you want to say that you can extend the schema, then a simple example would be helpful too.
Seems like this branch also need to be rebased (merge conflicts)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-217 : Adding documentati...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/203#issuecomment-129947130
### Documents are under Development
### Data Validation
### Introducing New Chart Library
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-217 : Adding documentati...
Posted by elbamos <gi...@git.apache.org>.
Github user elbamos commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/203#issuecomment-131611652
I don't mean to be a naysayer, and I agree that documentation on these topics would be very helpful. I also agree that this is a good starting point. I find both pages, though, very difficult to understand. Are these directions for implementing new interpreters? For users? For developing applications on top of Zeppelin?
> On Aug 16, 2015, at 12:36 PM, Lee moon soo <no...@github.com> wrote:
>
> Thanks for good documentation. LGTM!
>
> —
> Reply to this email directly or view it on GitHub.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-217 : Adding documentati...
Posted by elbamos <gi...@git.apache.org>.
Github user elbamos commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/203#issuecomment-133186523
This looks really helpful! I withdraw my prior objection.
> On Aug 17, 2015, at 4:37 AM, madhuka <no...@github.com> wrote:
>
> @elbamos Thanks for the feedback. A validator is important to determine the data maps to the schema without any errors beforehand. Yes it is complicated but I will write more simpler manner so that everybody can understand. It's not an interpreter. It's useful for users as well as for developers. Users can use the validator before visualization to check if the data is in accordance with the data model. It will not break and the user can take the right decision. For zeppelin developers when they introduce a new chart library they can add a validator for it so that users can validate the data before they visualize it.
>
> —
> Reply to this email directly or view it on GitHub.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-217 : Adding documentati...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/203#issuecomment-131579608
Thanks for good documentation. LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-217 : Adding documentati...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/203#issuecomment-133119288
Documentation updated with Tutorial with Map Visualization. Added screenshots for docs.
Tutorial with Map Visualization
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-217 : Adding documentati...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/203#issuecomment-131730647
@elbamos Thanks for the feedback. A validator is important to determine the data maps to the schema without any errors beforehand. Yes it is complicated but I will write more simpler manner so that everybody can understand. It's not an interpreter. It's useful for users as well as for developers. Users can use the validator before visualization to check if the data is in accordance with the data model. It will not break and the user can take the right decision. For zeppelin developers when they introduce a new chart library they can add a validator for it so that users can validate the data before they visualize it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-217 : Adding documentati...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/203#issuecomment-132867010
Data Validation Document is Updated with below sub titles.
* Where the data validator is used in zeppelin?
* Why the data validator is used?
* Why the data validator is important?
* How Data Validation is done?
* Adding new Data Range Validation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-217 : Adding documentati...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/203#issuecomment-131732377
@corneadoug
Yes I will write more descriptive documentation and add few sample code for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---