You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2017/05/04 22:05:25 UTC
[kudu-CR] tablet: revert batch-check-presence optimization for UPDATE/DELETE
David Ribeiro Alves has posted comments on this change.
Change subject: tablet: revert batch-check-presence optimization for UPDATE/DELETE
......................................................................
Patch Set 1:
(1 comment)
still want this reviewed?
(had an old unposted comment that I'll post now too)
http://gerrit.cloudera.org:8080/#/c/6577/1//COMMIT_MSG
Commit Message:
PS1, Line 37: for each op:
: if we noted a rowset above, apply there
: check bloom
: find the row index
: otherwise check MRS
this will still regress UPSERTS that transform to MUTATES right? (I guess we should monitor perf for those better)
--
To view, visit http://gerrit.cloudera.org:8080/6577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78e1e0a0293d737074e1309d2ef450c5439db2c6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes