You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "SoberChina (via GitHub)" <gi...@apache.org> on 2023/04/11 05:08:55 UTC
[GitHub] [incubator-streampark] SoberChina opened a new pull request, #2597: [Bug] Modifications should be disabled when building a project (#2596)
SoberChina opened a new pull request, #2597:
URL: https://github.com/apache/incubator-streampark/pull/2597
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
Issue Number: close #2596
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verifying this change
<!--*(Please pick either of the following options)*-->
When the build is triggered, the modify button is disabled. If an error message is displayed when modifying the project being built and saving it, errors cannot be correctly displayed when modifying the API. [code](https://github.com/apache/incubator-streampark/blob/14581ad0437b9e427b35fa661bf009f89b6e4c70/streampark-console/streampark-console-webapp/src/views/flink/project/Edit.vue#L80)
<!--*(example:)*
- *Added integration tests for end-to-end.*
- *Added *Test to verify the change.*
- *Manually verified the change by testing locally.* -->
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] SoberChina commented on a diff in pull request #2597: [Bug] Modifications should be disabled when building a project (#2596)
Posted by "SoberChina (via GitHub)" <gi...@apache.org>.
SoberChina commented on code in PR #2597:
URL: https://github.com/apache/incubator-streampark/pull/2597#discussion_r1163677388
##########
streampark-console/streampark-console-webapp/src/views/flink/project/components/ListItem.vue:
##########
@@ -89,13 +89,18 @@
</a-button>
</a-popconfirm>
</a-tooltip>
+ <a-tooltip :title="t('flink.project.operationTips.updateProject')">
+ <a-button v-auth="'project:update'" @click="handleEdit" shape="circle" class="ml-8px">
+ <EditOutlined />
+ </a-button>
+ </a-tooltip>
</template>
- <a-tooltip :title="t('flink.project.operationTips.updateProject')">
- <a-button v-auth="'project:update'" @click="handleEdit" shape="circle" class="ml-8px">
- <EditOutlined />
- </a-button>
- </a-tooltip>
+<!-- <a-tooltip :title="t('flink.project.operationTips.updateProject')">-->
Review Comment:
Oh, sorry for not cleaning up the previous code in a timely manner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2597: [Bug] Modifications should be disabled when building a project (#2596)
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on code in PR #2597:
URL: https://github.com/apache/incubator-streampark/pull/2597#discussion_r1163606706
##########
streampark-console/streampark-console-webapp/src/views/flink/project/components/ListItem.vue:
##########
@@ -89,13 +89,18 @@
</a-button>
</a-popconfirm>
</a-tooltip>
+ <a-tooltip :title="t('flink.project.operationTips.updateProject')">
Review Comment:
We need to judge whether the buildState of the current job is building, if building, disable edit button or edit button not display, else it is allowed to update
##########
streampark-console/streampark-console-webapp/src/views/flink/project/components/ListItem.vue:
##########
@@ -89,13 +89,18 @@
</a-button>
</a-popconfirm>
</a-tooltip>
+ <a-tooltip :title="t('flink.project.operationTips.updateProject')">
+ <a-button v-auth="'project:update'" @click="handleEdit" shape="circle" class="ml-8px">
+ <EditOutlined />
+ </a-button>
+ </a-tooltip>
</template>
- <a-tooltip :title="t('flink.project.operationTips.updateProject')">
- <a-button v-auth="'project:update'" @click="handleEdit" shape="circle" class="ml-8px">
- <EditOutlined />
- </a-button>
- </a-tooltip>
+<!-- <a-tooltip :title="t('flink.project.operationTips.updateProject')">-->
Review Comment:
What's this？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2597: [Bug] Modifications should be disabled when building a project (#2596)
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on code in PR #2597:
URL: https://github.com/apache/incubator-streampark/pull/2597#discussion_r1167933656
##########
streampark-console/streampark-console-webapp/src/views/flink/project/components/ListItem.vue:
##########
@@ -89,13 +89,18 @@
</a-button>
</a-popconfirm>
</a-tooltip>
+ <a-tooltip :title="t('flink.project.operationTips.updateProject')">
Review Comment:
> This logic is the same as [building](https://github.com/apache/incubator-streampark/blob/ed33ca2c0a773222071a22cf103aa44dc5d18e29/streampark-console/streampark-console-webapp/src/views/flink/project/components/ListItem.vue#L79).
yes, please update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] SoberChina commented on a diff in pull request #2597: [Bug] Modifications should be disabled when building a project (#2596)
Posted by "SoberChina (via GitHub)" <gi...@apache.org>.
SoberChina commented on code in PR #2597:
URL: https://github.com/apache/incubator-streampark/pull/2597#discussion_r1165261026
##########
streampark-console/streampark-console-webapp/src/views/flink/project/components/ListItem.vue:
##########
@@ -89,13 +89,18 @@
</a-button>
</a-popconfirm>
</a-tooltip>
+ <a-tooltip :title="t('flink.project.operationTips.updateProject')">
Review Comment:
This logic is the same as [building](https://github.com/apache/incubator-streampark/blob/ed33ca2c0a773222071a22cf103aa44dc5d18e29/streampark-console/streampark-console-webapp/src/views/flink/project/components/ListItem.vue#L79).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys merged pull request #2597: [Bug] Modifications should be disabled when building a project (#2596)
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #2597:
URL: https://github.com/apache/incubator-streampark/pull/2597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org