You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/13 22:14:01 UTC

[GitHub] [arrow] kou commented on pull request #33653: GH-15289: [Ruby] Return self when saving Table to csv

kou commented on PR #33653:
URL: https://github.com/apache/arrow/pull/33653#issuecomment-1382453422

   How about doing this in `TableSaver#save`?
   
   ```diff
   diff --git a/ruby/red-arrow/lib/arrow/table-saver.rb b/ruby/red-arrow/lib/arrow/table-saver.rb
   index f19261cced..c33e641438 100644
   --- a/ruby/red-arrow/lib/arrow/table-saver.rb
   +++ b/ruby/red-arrow/lib/arrow/table-saver.rb
   @@ -51,6 +51,7 @@ module Arrow
            raise ArgumentError, message
          end
          __send__(custom_save_method)
   +      @table
        end
    
        private
   
   ```
   
   If we did this in `TableSaver#save`, custom save method implementers don't need to care about this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org