[GitHub] [spark] cloud-fan commented on a change in pull request #24442: [SPARK-27547][SQL] fix DataFrame self-join problems

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #24442: [SPARK-27547][SQL] fix DataFrame self-join problems
URL: https://github.com/apache/spark/pull/24442#discussion_r277692238
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
 ##########
 @@ -2300,11 +2346,16 @@ class Dataset[T] private[sql](
           u.name, sparkSession.sessionState.analyzer.resolver).getOrElse(u)
       case Column(expr: Expression) => expr
     }
-    val attrs = this.logicalPlan.output
-    val colsAfterDrop = attrs.filter { attr =>
-      attr != expression
 
 Review comment:
   `drop` should not match attribute by equality. We should use `semanticEquals`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org