You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by devaraj-kavali <gi...@git.apache.org> on 2017/01/25 21:45:11 UTC

[GitHub] spark pull request #16705: [SPARK-19354] [Core] Killed tasks are getting mar...

GitHub user devaraj-kavali opened a pull request:

    https://github.com/apache/spark/pull/16705

    [SPARK-19354] [Core] Killed tasks are getting marked as FAILED

    ## What changes were proposed in this pull request?
    
    Handling the exception which occurs during the kill and logging it instead of re-throwing the exception which causes to mark the task as FAILED.
    
    ## How was this patch tested?
    
    I verified this manually by running multiple applications, with the patch changes when any exception occurs during kill, it logs the exception and continues with the kill process. It shows/considers the task as KILLED in Web UI sections of 'Details for Job' and 'Aggregated Metrics by Executor'.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/devaraj-kavali/spark SPARK-19354

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/16705.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16705
    
----
commit d472245bb7392db4dc1b260eeafba1470448ef03
Author: Devaraj K <de...@apache.org>
Date:   2017-01-25T21:33:09Z

    [SPARK-19354] [Core] Killed tasks are getting marked as FAILED

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16705: [SPARK-19354] [Core] Killed tasks are getting marked as ...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/16705
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16705: [SPARK-19354] [Core] Killed tasks are getting marked as ...

Posted by superbobry <gi...@git.apache.org>.

Github user superbobry commented on the issue:

    https://github.com/apache/spark/pull/16705
  
    Is there a chance to see this is 2.1.1?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16705: [SPARK-19354] [Core] Killed tasks are getting marked as ...

Posted by tgravescs <gi...@git.apache.org>.

Github user tgravescs commented on the issue:

    https://github.com/apache/spark/pull/16705
  
    Jenkins, test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16705: [SPARK-19354] [Core] Killed tasks are getting marked as ...

Posted by devaraj-kavali <gi...@git.apache.org>.

Github user devaraj-kavali commented on the issue:

    https://github.com/apache/spark/pull/16705
  
    Thanks @tgravescs for checking this, seems PR has gone stale, I will update it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16705: [SPARK-19354] [Core] Killed tasks are getting marked as ...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/16705
  
    **[Test build #76755 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76755/testReport)** for PR 16705 at commit [`d472245`](https://github.com/apache/spark/commit/d472245bb7392db4dc1b260eeafba1470448ef03).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16705: [SPARK-19354] [Core] Killed tasks are getting marked as ...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/16705
  
    **[Test build #76755 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76755/testReport)** for PR 16705 at commit [`d472245`](https://github.com/apache/spark/commit/d472245bb7392db4dc1b260eeafba1470448ef03).
     * This patch **fails to build**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16705: [SPARK-19354] [Core] Killed tasks are getting marked as ...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/16705
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76755/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16705: [SPARK-19354] [Core] Killed tasks are getting marked as ...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/16705
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org