You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2025/05/16 18:46:59 UTC
[PR] [Flaky-test] Fix QueryRunnerTest.testSqlWithExceptionMsgChecker() [pinot]
Jackie-Jiang opened a new pull request, #15825:
URL: https://github.com/apache/pinot/pull/15825
Fix the following error:
```
Error: Failures:
Error: QueryRunnerTest.testSqlWithExceptionMsgChecker:215 Exception should contain: Timeout, but found: Received 1 error from servers: Timed out on stage 0 waiting for data sent by a child stage expected [true] but found [false]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [Flaky-test] Fix QueryRunnerTest.testSqlWithExceptionMsgChecker() [pinot]
Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on code in PR #15825:
URL: https://github.com/apache/pinot/pull/15825#discussion_r2095249713
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/queries/QueryRunnerTest.java:
##########
@@ -313,9 +313,11 @@ protected Iterator<Object[]> provideTestSqlWithExecutionException() {
});
// Timeout exception should occur with this option:
+ // - If the query times out during submission, we get: "Error occurred during stage submission: Timeout"
+ // - If the query times out during execution, we get: "Timed out on stage 0 waiting for data sent by a child stage"
testCases.add(new Object[]{
"SET timeoutMs = 1; SELECT * FROM a JOIN b ON a.col1 = b.col1 JOIN c ON a.col1 = c.col1",
- "Timeout"
+ "Time"
Review Comment:
Isn't this too relaxed? It is fine to merge this PR to fix the flaky tests, but we would probably need to change the code to support regex so we can verify that it matches one of the two messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [Flaky-test] Fix QueryRunnerTest.testSqlWithExceptionMsgChecker() [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #15825:
URL: https://github.com/apache/pinot/pull/15825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [Flaky-test] Fix QueryRunnerTest.testSqlWithExceptionMsgChecker() [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #15825:
URL: https://github.com/apache/pinot/pull/15825#issuecomment-2887517192
### :x: Unsupported file format
> Upload processing failed due to unsupported file format. Please review the parser error message:
> `Error parsing JUnit XML in /home/runner/work/pinot/pinot/pinot-core/target/surefire-reports/TEST-org.apache.pinot.core.query.aggregation.groupby.GroupByTrimTest.xml at 62:2585
>
> Caused by:
> RuntimeError: Error validating attribute
>
> Caused by:
> string is too long`
> For more help, visit our [troubleshooting guide](https://docs.codecov.com/docs/test-analytics#troubleshooting).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org