You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HeartSaVioR <gi...@git.apache.org> on 2018/08/21 11:13:28 UTC
[GitHub] spark pull request #22170: [MINOR] Add .crc files to .gitignore
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/spark/pull/22170
[MINOR] Add .crc files to .gitignore
## What changes were proposed in this pull request?
Add .crc files to .gitignore so that we don't add .crc files in state checkpoint during tests to git repo.
This is based on comments in #21733, https://github.com/apache/spark/pull/21733#issuecomment-414578244.
## How was this patch tested?
Add `.1.delta.crc` and `.2.delta.crc` in `~/WorkArea/ScalaProjects/spark/sql/core/src/test/resources`, and confirm git doesn't suggest the files to add to stage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/spark add-crc-files-to-gitignore
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22170
----
commit da31ee6f302bdb4e2e3ec9af0c24a97146058d4f
Author: Jungtaek Lim <ka...@...>
Date: 2018-08-21T10:59:59Z
Add .crc files to .gitignore
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22170: [MINOR] Add .crc files to .gitignore
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22170
Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22170: [MINOR] Add .crc files to .gitignore
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22170
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95013/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22170: [MINOR] Add .crc files to .gitignore
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22170
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22170: [MINOR] Add .crc files to .gitignore
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22170
**[Test build #95013 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95013/testReport)** for PR 22170 at commit [`da31ee6`](https://github.com/apache/spark/commit/da31ee6f302bdb4e2e3ec9af0c24a97146058d4f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22170: [MINOR] Add .crc files to .gitignore
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22170
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22170: [MINOR] Add .crc files to .gitignore
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22170
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22170: [MINOR] Add .crc files to .gitignore
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/22170
cc. @tdas
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22170: [MINOR] Add .crc files to .gitignore
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22170
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22170: [MINOR] Add .crc files to .gitignore
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/22170
@HyukjinKwon Thanks for the reviewing and merging!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22170: [MINOR] Add .crc files to .gitignore
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22170
**[Test build #95013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95013/testReport)** for PR 22170 at commit [`da31ee6`](https://github.com/apache/spark/commit/da31ee6f302bdb4e2e3ec9af0c24a97146058d4f).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org