[GitHub] [arrow-datafusion] mustafasrepo commented on pull request #5661: Top down `EnforceSorting`, Extended testbench for `EnforceSorting` rule to prepare for refactors, additional functionality such as pushdowns over unions

["mustafasrepo (via GitHub)" <gi...@apache.org>]

mustafasrepo commented on PR #5661:
URL: https://github.com/apache/arrow-datafusion/pull/5661#issuecomment-1488149008

   
   
   
   
   > I suggest we split this PR into two
   > 
   > 1. The changes to the type signature of `ExecutionPlan` which while large is mostly mechanical
   > 2. The algorithm changes to `datafusion/core/src/physical_optimizer/sort_enforcement.rs` and `datafusion/core/src/physical_optimizer/sort_pushdown.rs`
   > 
   > I think we can get 1 in sooner -- I think after @mingmwang 's review of the algorithm we'll be ready for 2.
   
   I have moved the changes related signature of `ExecutionPlan` to another PR. New PR can be found in #5772. Thanks @alamb for the suggestion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org