[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1572: [CELEBORN-660][FLINK] Gen unique app id for Celeborn

["RexXiong (via GitHub)" <gi...@apache.org>]

RexXiong commented on code in PR #1572:
URL: https://github.com/apache/incubator-celeborn/pull/1572#discussion_r1225237164


##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleMaster.java:
##########
@@ -69,7 +71,6 @@ public void registerJob(JobShuffleContext context) {
       synchronized (RemoteShuffleMaster.class) {
         if (lifecycleManager == null) {
           // use first jobID as celeborn shared appId for all other flink jobs

Review Comment:
   Thanks @pan3793 , I have made some modifications to the code for doing best effort to keep original Flink JobId.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org