You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/24 00:46:17 UTC
[GitHub] [airflow] Taragolis opened a new pull request, #26648: Refactor `SlackWebhookOperator`: Get rid of mandatory http-provider dependency
Taragolis opened a new pull request, #26648:
URL: https://github.com/apache/airflow/pull/26648
follow-up: #26452
Right now `SlackWebhookOperator` based on `SimpleHttpOperator` but do not use any of parent attributes internally except http_conn_id. Mainly because `SlackWebhookOperator` entirely overwrite `execute` method and do not propagated `SimpleHttpOperator` attributes in hook constructor.
Since last changes in `SlackWebhookHook` also do not use anything from http-provider.
So there is not reason keep `apache-airflow-providers-http` as a dependency to the slack provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26648: Refactor `SlackWebhookOperator`: Get rid of mandatory http-provider dependency
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26648:
URL: https://github.com/apache/airflow/pull/26648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org