You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by "Weaver (EXT), Scott" <x_...@ugs.com> on 2005/07/27 21:22:18 UTC
All tests passing
All,
I have all tests passing in my environment now (including the remaining
broken ones that David Taylor pointed out in his email set on Monday).
Does everyone want me to commit my changes to the trunk or should I
create a branch? I have made some (but not all) changes which I
proposed in my previous email. The biggest change to the core is the
navigational state components which were moved to their own Spring
configuration. Also, JetspeedNavigationalStateComponent no longer
creates classes on the fly, instead it has been made BeanFactoryAware
and pulls NavState and PortletURL instances directly from Spring. FYI:
NavState and PortalURL definitions in Spring are required to be
singleton="no".
Regards,
Scott
RE: All tests passing
Posted by Scott T Weaver <sc...@binary-designs.net>.
All commits are in.
Regards,
-Scott
> -----Original Message-----
> From: Randy Watler [mailto:watler@wispertel.net]
> Sent: Wednesday, July 27, 2005 4:19 PM
> To: Jetspeed Developers List
> Subject: Re: All tests passing
>
> Scott,
>
> +1... thanks for looking at this.
>
> Randy
>
> Weaver (EXT), Scott wrote:
>
> >All,
> >
> >
> >
> >I have all tests passing in my environment now (including the remaining
> >broken ones that David Taylor pointed out in his email set on Monday).
> >
> >
> >
> >Does everyone want me to commit my changes to the trunk or should I
> >create a branch? I have made some (but not all) changes which I
> >proposed in my previous email. The biggest change to the core is the
> >navigational state components which were moved to their own Spring
> >configuration. Also, JetspeedNavigationalStateComponent no longer
> >creates classes on the fly, instead it has been made BeanFactoryAware
> >and pulls NavState and PortletURL instances directly from Spring. FYI:
> >NavState and PortalURL definitions in Spring are required to be
> >singleton="no".
> >
> >
> >
> >Regards,
> >
> >Scott
> >
> >
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
Re: All tests passing
Posted by Randy Watler <wa...@wispertel.net>.
Scott,
+1... thanks for looking at this.
Randy
Weaver (EXT), Scott wrote:
>All,
>
>
>
>I have all tests passing in my environment now (including the remaining
>broken ones that David Taylor pointed out in his email set on Monday).
>
>
>
>Does everyone want me to commit my changes to the trunk or should I
>create a branch? I have made some (but not all) changes which I
>proposed in my previous email. The biggest change to the core is the
>navigational state components which were moved to their own Spring
>configuration. Also, JetspeedNavigationalStateComponent no longer
>creates classes on the fly, instead it has been made BeanFactoryAware
>and pulls NavState and PortletURL instances directly from Spring. FYI:
>NavState and PortalURL definitions in Spring are required to be
>singleton="no".
>
>
>
>Regards,
>
>Scott
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
RE: All tests passing
Posted by Scott T Weaver <sc...@binary-designs.net>.
Oops, replied to the wrong email.
> -----Original Message-----
> From: Scott T Weaver [mailto:scotts-jetspeed-list@binary-designs.net]
> Sent: Wednesday, July 27, 2005 4:18 PM
> To: 'Jetspeed Developers List'
> Subject: RE: All tests passing
>
> +1, but please wait until after I finish committing.
>
> Thanks,
> -Scott
>
> > -----Original Message-----
> > From: Ate Douma [mailto:ate@douma.nu]
> > Sent: Wednesday, July 27, 2005 3:49 PM
> > To: Jetspeed Developers List
> > Subject: Re: All tests passing
> >
> > David Le Strat wrote:
> > > +1 for committing to trunk if this addresses the
> > > current unit tests issues.
> > I'll second that: +1
> >
> > >
> > > --- "Weaver (EXT), Scott" <x_...@ugs.com> wrote:
> > >
> > >
> > >>All,
> > >>
> > >>
> > >>
> > >>I have all tests passing in my environment now
> > >>(including the remaining
> > >>broken ones that David Taylor pointed out in his
> > >>email set on Monday).
> > >>
> > >>
> > >>
> > >>Does everyone want me to commit my changes to the
> > >>trunk or should I
> > >>create a branch? I have made some (but not all)
> > >>changes which I
> > >>proposed in my previous email. The biggest change
> > >>to the core is the
> > >>navigational state components which were moved to
> > >>their own Spring
> > >>configuration. Also,
> > >>JetspeedNavigationalStateComponent no longer
> > >>creates classes on the fly, instead it has been made
> > >>BeanFactoryAware
> > >>and pulls NavState and PortletURL instances directly
> > >>from Spring. FYI:
> > >>NavState and PortalURL definitions in Spring are
> > >>required to be
> > >>singleton="no".
> > >>
> > >>
> > >>
> > >>Regards,
> > >>
> > >>Scott
> > >>
> > >>
> > >
> > >
> > >
> > > ________________________
> > > David Le Strat
> > > Blogging @ http://dlsthoughts.blogspot.com
> > >
> > >
> > >
> > > ____________________________________________________
> > > Start your day with Yahoo! - make it your home page
> > > http://www.yahoo.com/r/hs
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> > > For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> > For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
RE: All tests passing
Posted by Scott T Weaver <sc...@binary-designs.net>.
+1, but please wait until after I finish committing.
Thanks,
-Scott
> -----Original Message-----
> From: Ate Douma [mailto:ate@douma.nu]
> Sent: Wednesday, July 27, 2005 3:49 PM
> To: Jetspeed Developers List
> Subject: Re: All tests passing
>
> David Le Strat wrote:
> > +1 for committing to trunk if this addresses the
> > current unit tests issues.
> I'll second that: +1
>
> >
> > --- "Weaver (EXT), Scott" <x_...@ugs.com> wrote:
> >
> >
> >>All,
> >>
> >>
> >>
> >>I have all tests passing in my environment now
> >>(including the remaining
> >>broken ones that David Taylor pointed out in his
> >>email set on Monday).
> >>
> >>
> >>
> >>Does everyone want me to commit my changes to the
> >>trunk or should I
> >>create a branch? I have made some (but not all)
> >>changes which I
> >>proposed in my previous email. The biggest change
> >>to the core is the
> >>navigational state components which were moved to
> >>their own Spring
> >>configuration. Also,
> >>JetspeedNavigationalStateComponent no longer
> >>creates classes on the fly, instead it has been made
> >>BeanFactoryAware
> >>and pulls NavState and PortletURL instances directly
> >>from Spring. FYI:
> >>NavState and PortalURL definitions in Spring are
> >>required to be
> >>singleton="no".
> >>
> >>
> >>
> >>Regards,
> >>
> >>Scott
> >>
> >>
> >
> >
> >
> > ________________________
> > David Le Strat
> > Blogging @ http://dlsthoughts.blogspot.com
> >
> >
> >
> > ____________________________________________________
> > Start your day with Yahoo! - make it your home page
> > http://www.yahoo.com/r/hs
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> > For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
> >
> >
> >
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
RE: All tests passing
Posted by Scott T Weaver <sc...@binary-designs.net>.
Ok, I needed to test a running portal and it looks like everything is
working. I had a little issue starting out because I accidentally deleted
my JDBC driver when I cleaned out shared/lib (now it's in common/lib to
avoid this in the future). I am going to start committing. FYI: It appears
that most of the Security tests fail on subsequent test runs. I am guessing
this has to do with DB cleanup. David, can you look into this? However,
they all run fine on a fresh DB.
Regards,
Scott
> -----Original Message-----
> From: Ate Douma [mailto:ate@douma.nu]
> Sent: Wednesday, July 27, 2005 3:49 PM
> To: Jetspeed Developers List
> Subject: Re: All tests passing
>
> David Le Strat wrote:
> > +1 for committing to trunk if this addresses the
> > current unit tests issues.
> I'll second that: +1
>
> >
> > --- "Weaver (EXT), Scott" <x_...@ugs.com> wrote:
> >
> >
> >>All,
> >>
> >>
> >>
> >>I have all tests passing in my environment now
> >>(including the remaining
> >>broken ones that David Taylor pointed out in his
> >>email set on Monday).
> >>
> >>
> >>
> >>Does everyone want me to commit my changes to the
> >>trunk or should I
> >>create a branch? I have made some (but not all)
> >>changes which I
> >>proposed in my previous email. The biggest change
> >>to the core is the
> >>navigational state components which were moved to
> >>their own Spring
> >>configuration. Also,
> >>JetspeedNavigationalStateComponent no longer
> >>creates classes on the fly, instead it has been made
> >>BeanFactoryAware
> >>and pulls NavState and PortletURL instances directly
> >>from Spring. FYI:
> >>NavState and PortalURL definitions in Spring are
> >>required to be
> >>singleton="no".
> >>
> >>
> >>
> >>Regards,
> >>
> >>Scott
> >>
> >>
> >
> >
> >
> > ________________________
> > David Le Strat
> > Blogging @ http://dlsthoughts.blogspot.com
> >
> >
> >
> > ____________________________________________________
> > Start your day with Yahoo! - make it your home page
> > http://www.yahoo.com/r/hs
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> > For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
> >
> >
> >
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
Re: All tests passing
Posted by Ate Douma <at...@douma.nu>.
David Le Strat wrote:
> +1 for committing to trunk if this addresses the
> current unit tests issues.
I'll second that: +1
>
> --- "Weaver (EXT), Scott" <x_...@ugs.com> wrote:
>
>
>>All,
>>
>>
>>
>>I have all tests passing in my environment now
>>(including the remaining
>>broken ones that David Taylor pointed out in his
>>email set on Monday).
>>
>>
>>
>>Does everyone want me to commit my changes to the
>>trunk or should I
>>create a branch? I have made some (but not all)
>>changes which I
>>proposed in my previous email. The biggest change
>>to the core is the
>>navigational state components which were moved to
>>their own Spring
>>configuration. Also,
>>JetspeedNavigationalStateComponent no longer
>>creates classes on the fly, instead it has been made
>>BeanFactoryAware
>>and pulls NavState and PortletURL instances directly
>>from Spring. FYI:
>>NavState and PortalURL definitions in Spring are
>>required to be
>>singleton="no".
>>
>>
>>
>>Regards,
>>
>>Scott
>>
>>
>
>
>
> ________________________
> David Le Strat
> Blogging @ http://dlsthoughts.blogspot.com
>
>
>
> ____________________________________________________
> Start your day with Yahoo! - make it your home page
> http://www.yahoo.com/r/hs
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
Re: [J2] Patch JS2-297
Posted by Randy Watler <wa...@wispertel.net>.
+1,
Randy
David Le Strat wrote:
>All,
>
>I would like to apply patch JS2-297:
>
>http://issues.apache.org/jira/browse/JS2-297
>
>Let me know if you have any issues with me doing so.
>
>Regards,
>
>David Le Strat.
>
>________________________
>David Le Strat
>Blogging @ http://dlsthoughts.blogspot.com
>
>
>
>____________________________________________________
>Start your day with Yahoo! - make it your home page
>http://www.yahoo.com/r/hs
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
>For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
RE: [J2] Patch JS2-297
Posted by Scott T Weaver <sc...@binary-designs.net>.
+1, but please wait until after I finish committing.
> -----Original Message-----
> From: David Le Strat [mailto:dlestrat@yahoo.com]
> Sent: Wednesday, July 27, 2005 3:58 PM
> To: Jetspeed Developers List
> Subject: [J2] Patch JS2-297
>
> All,
>
> I would like to apply patch JS2-297:
>
> http://issues.apache.org/jira/browse/JS2-297
>
> Let me know if you have any issues with me doing so.
>
> Regards,
>
> David Le Strat.
>
> ________________________
> David Le Strat
> Blogging @ http://dlsthoughts.blogspot.com
>
>
>
> ____________________________________________________
> Start your day with Yahoo! - make it your home page
> http://www.yahoo.com/r/hs
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[J2] Patch JS2-297
Posted by David Le Strat <dl...@yahoo.com>.
All,
I would like to apply patch JS2-297:
http://issues.apache.org/jira/browse/JS2-297
Let me know if you have any issues with me doing so.
Regards,
David Le Strat.
________________________
David Le Strat
Blogging @ http://dlsthoughts.blogspot.com
____________________________________________________
Start your day with Yahoo! - make it your home page
http://www.yahoo.com/r/hs
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
Re: All tests passing
Posted by David Le Strat <dl...@yahoo.com>.
+1 for committing to trunk if this addresses the
current unit tests issues.
--- "Weaver (EXT), Scott" <x_...@ugs.com> wrote:
> All,
>
>
>
> I have all tests passing in my environment now
> (including the remaining
> broken ones that David Taylor pointed out in his
> email set on Monday).
>
>
>
> Does everyone want me to commit my changes to the
> trunk or should I
> create a branch? I have made some (but not all)
> changes which I
> proposed in my previous email. The biggest change
> to the core is the
> navigational state components which were moved to
> their own Spring
> configuration. Also,
> JetspeedNavigationalStateComponent no longer
> creates classes on the fly, instead it has been made
> BeanFactoryAware
> and pulls NavState and PortletURL instances directly
> from Spring. FYI:
> NavState and PortalURL definitions in Spring are
> required to be
> singleton="no".
>
>
>
> Regards,
>
> Scott
>
>
________________________
David Le Strat
Blogging @ http://dlsthoughts.blogspot.com
____________________________________________________
Start your day with Yahoo! - make it your home page
http://www.yahoo.com/r/hs
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org