[GitHub] [flink] tzulitai commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

["tzulitai (via GitHub)" <gi...@apache.org>]

tzulitai commented on code in PR #22303:
URL: https://github.com/apache/flink/pull/22303#discussion_r1152597944


##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java:
##########
@@ -420,6 +420,7 @@ private void checkAsyncException() throws IOException {
         if (e != null) {
 
             asyncProducerException = null;
+            numRecordsOutErrorsCounter.inc();

Review Comment:
   Is there a test that covers this? Looks like we missed this as well in the initial PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org