You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by nellboy <gi...@git.apache.org> on 2017/02/20 17:33:07 UTC
[GitHub] flink pull request #3369: [FLINK-5831] [webui] order, search and filter metr...
GitHub user nellboy opened a pull request:
https://github.com/apache/flink/pull/3369
[FLINK-5831] [webui] order, search and filter metrics
Metrics are now ordered, and searchable when displaying which metrics graphs to display in the web ui.

You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nellboy/flink webui/metrics-filtering
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3369.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3369
----
commit 730e7b6d3b35855d93049e48850ca5919f7db968
Author: paul <ne...@gmail.com>
Date: 2017-02-20T09:28:14Z
[FLINK-5831] [webui] sort metrics by id
commit 45f5c565d9a805f78c40ed8ad7cc497aaf5c438f
Author: paul <ne...@gmail.com>
Date: 2017-02-20T17:27:13Z
[FLINK-5831] [webui] order, search and filter metrics
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3369: [FLINK-5831] [webui] order, search and filter metrics
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3369
@nellboy please rebase to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3369: [FLINK-5831] [webui] order, search and filter metrics
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3369
Thank you for opening a pull request addressing the issue.
I know it is out of scope of the JIRA, but since you are working on it already, I was wondering if we can improve the optics of the metric selector dropdown a bit.
I think it would look much nicer, if the search text field spans the entire width of the box, and if the selectable entries are aligned on the left.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3369: [FLINK-5831] [webui] order, search and filter metrics
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3369
@nellboy and also thanks for this contribution! Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3369: [FLINK-5831] [webui] order, search and filter metr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3369
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3369: [FLINK-5831] [webui] order, search and filter metrics
Posted by nellboy <gi...@git.apache.org>.
Github user nellboy commented on the issue:
https://github.com/apache/flink/pull/3369
Ok, this has been updated now.

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3369: [FLINK-5831] [webui] order, search and filter metrics
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3369
Cool, very nice!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---