You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "darshan-sj (via GitHub)" <gi...@apache.org> on 2023/03/28 04:27:18 UTC

[GitHub] [beam] darshan-sj opened a new pull request, #26007: Adding support for Spanner Databoost in SpannerIO

darshan-sj opened a new pull request, #26007:
URL: https://github.com/apache/beam/pull/26007

   Adding support for Spanner Databoost (Offline access) in SpannerIO
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] darshan-sj commented on a diff in pull request #26007: Adding support for Spanner Databoost in SpannerIO

Posted by "darshan-sj (via GitHub)" <gi...@apache.org>.
darshan-sj commented on code in PR #26007:
URL: https://github.com/apache/beam/pull/26007#discussion_r1155065856


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/BatchSpannerRead.java:
##########
@@ -138,6 +138,9 @@ public void processElement(ProcessContext c) throws Exception {
       BatchReadOnlyTransaction batchTx =
           spannerAccessor.getBatchClient().batchReadOnlyTransaction(tx.transactionId());
       ReadOperation op = c.element();
+      boolean dataBoostEnabled =
+          config.getDataBoostEnabled() != null
+              && Boolean.TRUE.equals(config.getDataBoostEnabled().get());

Review Comment:
   Since config.getDataBoostEnabled().get() is a Boolean, I thought it can be null as well. Thats why I wrote this way. Can it never be null?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #26007: Adding support for Spanner Databoost in SpannerIO

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26007:
URL: https://github.com/apache/beam/pull/26007#issuecomment-1494387408

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @robertwb for label java.
   R: @johnjcasey for label io.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nielm commented on a diff in pull request #26007: Adding support for Spanner Databoost in SpannerIO

Posted by "nielm (via GitHub)" <gi...@apache.org>.
nielm commented on code in PR #26007:
URL: https://github.com/apache/beam/pull/26007#discussion_r1155065869


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########
@@ -109,20 +112,26 @@ public static SpannerAccessor getOrCreate(SpannerConfig spannerConfig) {
   private static SpannerAccessor createAndConnect(SpannerConfig spannerConfig) {
     SpannerOptions.Builder builder = SpannerOptions.newBuilder();
 
-    // Set retryable codes for all API methods
+    Set<Code> retryableCodes = new HashSet<>();
     if (spannerConfig.getRetryableCodes() != null) {
-      builder
-          .getSpannerStubSettingsBuilder()
-          .applyToAllUnaryMethods(
-              input -> {
-                input.setRetryableCodes(spannerConfig.getRetryableCodes());
-                return null;
-              });
-      builder
-          .getSpannerStubSettingsBuilder()
-          .executeStreamingSqlSettings()
-          .setRetryableCodes(spannerConfig.getRetryableCodes());
+      retryableCodes.addAll(spannerConfig.getRetryableCodes());
+    }
+    if (spannerConfig.getDataBoostEnabled() != null
+        && Boolean.TRUE.equals(spannerConfig.getDataBoostEnabled().get())) {

Review Comment:
   Same comment as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] darshan-sj commented on pull request #26007: Adding support for Spanner Databoost in SpannerIO

Posted by "darshan-sj (via GitHub)" <gi...@apache.org>.
darshan-sj commented on PR #26007:
URL: https://github.com/apache/beam/pull/26007#issuecomment-1494708030

   Run Java_GCP_IO_Direct PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nielm commented on a diff in pull request #26007: Adding support for Spanner Databoost in SpannerIO

Posted by "nielm (via GitHub)" <gi...@apache.org>.
nielm commented on code in PR #26007:
URL: https://github.com/apache/beam/pull/26007#discussion_r1155065855


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########
@@ -109,20 +112,26 @@ public static SpannerAccessor getOrCreate(SpannerConfig spannerConfig) {
   private static SpannerAccessor createAndConnect(SpannerConfig spannerConfig) {
     SpannerOptions.Builder builder = SpannerOptions.newBuilder();
 
-    // Set retryable codes for all API methods
+    Set<Code> retryableCodes = new HashSet<>();

Review Comment:
   You can move this into the else block



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] darshan-sj commented on pull request #26007: Adding support for Spanner Databoost in SpannerIO

Posted by "darshan-sj (via GitHub)" <gi...@apache.org>.
darshan-sj commented on PR #26007:
URL: https://github.com/apache/beam/pull/26007#issuecomment-1494301079

   Added the SpannerRead integration test with dataBoostEnabled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nielm commented on a diff in pull request #26007: Adding support for Spanner Databoost in SpannerIO

Posted by "nielm (via GitHub)" <gi...@apache.org>.
nielm commented on code in PR #26007:
URL: https://github.com/apache/beam/pull/26007#discussion_r1155065248


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/BatchSpannerRead.java:
##########
@@ -138,6 +138,9 @@ public void processElement(ProcessContext c) throws Exception {
       BatchReadOnlyTransaction batchTx =
           spannerAccessor.getBatchClient().batchReadOnlyTransaction(tx.transactionId());
       ReadOperation op = c.element();
+      boolean dataBoostEnabled =
+          config.getDataBoostEnabled() != null
+              && Boolean.TRUE.equals(config.getDataBoostEnabled().get());

Review Comment:
   There is no need for the `Boolean.TRUE.equals()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] darshan-sj commented on a diff in pull request #26007: Adding support for Spanner Databoost in SpannerIO

Posted by "darshan-sj (via GitHub)" <gi...@apache.org>.
darshan-sj commented on code in PR #26007:
URL: https://github.com/apache/beam/pull/26007#discussion_r1155940743


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/BatchSpannerRead.java:
##########
@@ -138,6 +138,9 @@ public void processElement(ProcessContext c) throws Exception {
       BatchReadOnlyTransaction batchTx =
           spannerAccessor.getBatchClient().batchReadOnlyTransaction(tx.transactionId());
       ReadOperation op = c.element();
+      boolean dataBoostEnabled =
+          config.getDataBoostEnabled() != null
+              && Boolean.TRUE.equals(config.getDataBoostEnabled().get());

Review Comment:
   Done.



##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########
@@ -109,20 +112,26 @@ public static SpannerAccessor getOrCreate(SpannerConfig spannerConfig) {
   private static SpannerAccessor createAndConnect(SpannerConfig spannerConfig) {
     SpannerOptions.Builder builder = SpannerOptions.newBuilder();
 
-    // Set retryable codes for all API methods
+    Set<Code> retryableCodes = new HashSet<>();
     if (spannerConfig.getRetryableCodes() != null) {
-      builder
-          .getSpannerStubSettingsBuilder()
-          .applyToAllUnaryMethods(
-              input -> {
-                input.setRetryableCodes(spannerConfig.getRetryableCodes());
-                return null;
-              });
-      builder
-          .getSpannerStubSettingsBuilder()
-          .executeStreamingSqlSettings()
-          .setRetryableCodes(spannerConfig.getRetryableCodes());
+      retryableCodes.addAll(spannerConfig.getRetryableCodes());
+    }
+    if (spannerConfig.getDataBoostEnabled() != null
+        && Boolean.TRUE.equals(spannerConfig.getDataBoostEnabled().get())) {

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] darshan-sj commented on a diff in pull request #26007: Adding support for Spanner Databoost in SpannerIO

Posted by "darshan-sj (via GitHub)" <gi...@apache.org>.
darshan-sj commented on code in PR #26007:
URL: https://github.com/apache/beam/pull/26007#discussion_r1155943653


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########
@@ -109,20 +112,26 @@ public static SpannerAccessor getOrCreate(SpannerConfig spannerConfig) {
   private static SpannerAccessor createAndConnect(SpannerConfig spannerConfig) {
     SpannerOptions.Builder builder = SpannerOptions.newBuilder();
 
-    // Set retryable codes for all API methods
+    Set<Code> retryableCodes = new HashSet<>();

Review Comment:
   spannerConfig.getRetryableCodes() returns an ImmutableSet. So, I have to create a new HashSet and then add all the retryable codes for these 2 conditions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] darshan-sj commented on pull request #26007: Adding support for Spanner Databoost in SpannerIO

Posted by "darshan-sj (via GitHub)" <gi...@apache.org>.
darshan-sj commented on PR #26007:
URL: https://github.com/apache/beam/pull/26007#issuecomment-1496170845

   Run Spotless PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #26007: Adding support for Spanner Databoost in SpannerIO

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26007:
URL: https://github.com/apache/beam/pull/26007#issuecomment-1486221620

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26007: Adding support for Spanner Databoost in SpannerIO

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26007:
URL: https://github.com/apache/beam/pull/26007#issuecomment-1496135666

   Jenkins trigger seems not working. I am closing and reopen it to trigger tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn merged pull request #26007: Adding support for Spanner Databoost in SpannerIO

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #26007:
URL: https://github.com/apache/beam/pull/26007


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] darshan-sj commented on pull request #26007: Adding support for Spanner Databoost in SpannerIO

Posted by "darshan-sj (via GitHub)" <gi...@apache.org>.
darshan-sj commented on PR #26007:
URL: https://github.com/apache/beam/pull/26007#issuecomment-1492839293

   @pabloem @nielm Please review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org