You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/29 06:44:01 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
AngersZhuuuu opened a new pull request #34434:
URL: https://github.com/apache/spark/pull/34434
### What changes were proposed in this pull request?
We have remove the code about check supported functions https://github.com/apache/spark/pull/34410 , in this pr add doc about hive built-in functions that spark not supported.
Then we can have a place to explain with user and show this.
### Why are the changes needed?
Improve doc
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Not need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34434:
URL: https://github.com/apache/spark/pull/34434#issuecomment-954490481
**[Test build #144743 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144743/testReport)** for PR 34434 at commit [`7d575b4`](https://github.com/apache/spark/commit/7d575b436a1f1bb4816d06bf1c005f158f235b61).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34434:
URL: https://github.com/apache/spark/pull/34434#issuecomment-954545315
Hive can add new built-in functions. It's not realistic that we follow such Hive built-in functions and maintenance our docs right?
We have a doc which lists built-in functions Spark supports. It's enough isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34434:
URL: https://github.com/apache/spark/pull/34434#issuecomment-954497526
**[Test build #144743 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144743/testReport)** for PR 34434 at commit [`7d575b4`](https://github.com/apache/spark/commit/7d575b436a1f1bb4816d06bf1c005f158f235b61).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #34434:
URL: https://github.com/apache/spark/pull/34434#issuecomment-954545315
Hive can add new built-in functions. It's not realistic that we keep following such Hive built-in functions and maintain our docs right?
We already have a doc which lists built-in functions Spark supports. It's enough isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34434:
URL: https://github.com/apache/spark/pull/34434#issuecomment-954497780
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144743/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34434:
URL: https://github.com/apache/spark/pull/34434#issuecomment-954583733
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49212/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34434:
URL: https://github.com/apache/spark/pull/34434#issuecomment-954564829
+1 to what @sarutak said.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #34434:
URL: https://github.com/apache/spark/pull/34434#issuecomment-954474621
ping @HyukjinKwon @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #34434:
URL: https://github.com/apache/spark/pull/34434#issuecomment-954545315
Hive can add new built-in functions. It's not realistic that we keep following such Hive built-in functions and maintain our docs right?
We have a doc which lists built-in functions Spark supports. It's enough isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34434:
URL: https://github.com/apache/spark/pull/34434#issuecomment-954577811
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49212/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu closed pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu closed pull request #34434:
URL: https://github.com/apache/spark/pull/34434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34434:
URL: https://github.com/apache/spark/pull/34434#issuecomment-954497780
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144743/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34434:
URL: https://github.com/apache/spark/pull/34434#issuecomment-954526314
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49212/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34434:
URL: https://github.com/apache/spark/pull/34434#issuecomment-954583733
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49212/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34434:
URL: https://github.com/apache/spark/pull/34434#issuecomment-954490481
**[Test build #144743 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144743/testReport)** for PR 34434 at commit [`7d575b4`](https://github.com/apache/spark/commit/7d575b436a1f1bb4816d06bf1c005f158f235b61).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #34434:
URL: https://github.com/apache/spark/pull/34434#issuecomment-954583587
Yea, close this,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #34434: [SPARK-37158][DOC] Add doc about spark not supported hive built-in functions
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #34434:
URL: https://github.com/apache/spark/pull/34434#issuecomment-954545315
Hive can add new built-in functions. It's not realistic that we follow such Hive built-in functions and maintain our docs right?
We have a doc which lists built-in functions Spark supports. It's enough isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org