[GitHub] [superset] villebro commented on pull request #14217: feat(native-filters): select group by support

[GitBox <gi...@apache.org>]

villebro commented on pull request #14217:
URL: https://github.com/apache/superset/pull/14217#issuecomment-823349828


   > > 1. Saved native groupby filters should be carried back to Explore view, with the warning sign, for consistency. Unless we want to change the existing behavior for all. 🌕
   
   We'd need to add some new fields to the `QueryFormData` schema to be able to relay information about which columns originated from a cross drilldown/groupby. That feature is beyond the scope of this PR.
   
   > > 2. Add drag and drop in native filter for reordering select values. Since order actually matters now. 🌕
   
   As long as this component is based on AntD, it's going to be difficult to add DnD, as the AntD Select component doesn't natively support reordering.
   
   > cross filter scoping is already enforcing the scope of groupby , we should generify the naming here :
   > filters-->actions(or something)
   > cross (?) or interactive
   
   Agreed, we need to finalize the naming here, it's difficult to talk about these features when we have many names for the same functionality.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org