You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/11/03 23:19:24 UTC
Review Request: Using minified javascript in the webui.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7855/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
Saves around 750KB of content to send over the wire, for little effort.
Diffs
-----
src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
src/webui/master/static/angular-1.0.0rc8.min.js PRE-CREATION
src/webui/master/static/bootstrap/js/jquery-1.7.1.min.js PRE-CREATION
src/webui/master/static/cubism.v1.min.js PRE-CREATION
src/webui/master/static/d3.v2.min.js PRE-CREATION
src/webui/master/static/index.html 5e03ef6d054fab962657c1598888e65232f4c7e3
Diff: https://reviews.apache.org/r/7855/diff/
Testing
-------
Local runs, made sure to not forget adding to the Makefile this time.
Thanks,
Ben Mahler
Re: Review Request: Using minified javascript in the webui.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7855/#review13236
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Nov. 6, 2012, 6:23 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7855/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2012, 6:23 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Saves around 750KB of content to send over the wire, for little effort.
>
>
> Diffs
> -----
>
> src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
> src/webui/master/static/angular-1.0.0rc8.min.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery-1.7.1.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery-1.7.1.min.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery.js 00c4e23a27b15f6158ea46a016beb0ae95c6596d
> src/webui/master/static/cubism.v1.min.js PRE-CREATION
> src/webui/master/static/d3.v2.min.js PRE-CREATION
> src/webui/master/static/index.html 5e03ef6d054fab962657c1598888e65232f4c7e3
> src/webui/master/static/pailer.html 80dcd7b349582cb1875d1a72745c9c22394c0a26
> src/webui/master/static/underscore-1.3.3.min.js PRE-CREATION
> src/webui/master/static/underscore-min.js 5a0cb3b008d213ef3ecd3147c51eed08d98e2c54
>
> Diff: https://reviews.apache.org/r/7855/diff/
>
>
> Testing
> -------
>
> Local runs, made sure to not forget adding to the Makefile this time.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Using minified javascript in the webui.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7855/#review14106
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Nov. 6, 2012, 6:23 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7855/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2012, 6:23 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Saves around 750KB of content to send over the wire, for little effort.
>
>
> Diffs
> -----
>
> src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
> src/webui/master/static/angular-1.0.0rc8.min.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery-1.7.1.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery-1.7.1.min.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery.js 00c4e23a27b15f6158ea46a016beb0ae95c6596d
> src/webui/master/static/cubism.v1.min.js PRE-CREATION
> src/webui/master/static/d3.v2.min.js PRE-CREATION
> src/webui/master/static/index.html 5e03ef6d054fab962657c1598888e65232f4c7e3
> src/webui/master/static/pailer.html 80dcd7b349582cb1875d1a72745c9c22394c0a26
> src/webui/master/static/underscore-1.3.3.min.js PRE-CREATION
> src/webui/master/static/underscore-min.js 5a0cb3b008d213ef3ecd3147c51eed08d98e2c54
>
> Diff: https://reviews.apache.org/r/7855/diff/
>
>
> Testing
> -------
>
> Local runs, made sure to not forget adding to the Makefile this time.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Using minified javascript in the webui.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7855/
-----------------------------------------------------------
(Updated Nov. 6, 2012, 6:23 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Got the diff up once I took out the following from my gitconfig:
[diff]
renames = true
copies = true
Description
-------
Saves around 750KB of content to send over the wire, for little effort.
Diffs (updated)
-----
src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
src/webui/master/static/angular-1.0.0rc8.min.js PRE-CREATION
src/webui/master/static/bootstrap/js/jquery-1.7.1.js PRE-CREATION
src/webui/master/static/bootstrap/js/jquery-1.7.1.min.js PRE-CREATION
src/webui/master/static/bootstrap/js/jquery.js 00c4e23a27b15f6158ea46a016beb0ae95c6596d
src/webui/master/static/cubism.v1.min.js PRE-CREATION
src/webui/master/static/d3.v2.min.js PRE-CREATION
src/webui/master/static/index.html 5e03ef6d054fab962657c1598888e65232f4c7e3
src/webui/master/static/pailer.html 80dcd7b349582cb1875d1a72745c9c22394c0a26
src/webui/master/static/underscore-1.3.3.min.js PRE-CREATION
src/webui/master/static/underscore-min.js 5a0cb3b008d213ef3ecd3147c51eed08d98e2c54
Diff: https://reviews.apache.org/r/7855/diff/
Testing
-------
Local runs, made sure to not forget adding to the Makefile this time.
Thanks,
Ben Mahler
Re: Review Request: Using minified javascript in the webui.
Posted by Ben Mahler <be...@gmail.com>.
> On Nov. 6, 2012, 6:17 a.m., Ben Mahler wrote:
> >
>
> Ben Mahler wrote:
> Reviewboard is not letting me update the diff on this one:
>
> >>> Error data: {u'stat': u'fail', u'file': u'src/webui/master/static/bootstrap/js/jquery.js', u'err': {u'msg': u'The file was not found in the repository', u'code': 207}, u'revision': ''}
>
> Will see if a new review is ok.
No luck with a new review either.. perhaps reviewboard doesn't like 'git mv'
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7855/#review13124
-----------------------------------------------------------
On Nov. 3, 2012, 10:19 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7855/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2012, 10:19 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Saves around 750KB of content to send over the wire, for little effort.
>
>
> Diffs
> -----
>
> src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
> src/webui/master/static/angular-1.0.0rc8.min.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery-1.7.1.min.js PRE-CREATION
> src/webui/master/static/cubism.v1.min.js PRE-CREATION
> src/webui/master/static/d3.v2.min.js PRE-CREATION
> src/webui/master/static/index.html 5e03ef6d054fab962657c1598888e65232f4c7e3
>
> Diff: https://reviews.apache.org/r/7855/diff/
>
>
> Testing
> -------
>
> Local runs, made sure to not forget adding to the Makefile this time.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Using minified javascript in the webui.
Posted by Ben Mahler <be...@gmail.com>.
> On Nov. 6, 2012, 6:17 a.m., Ben Mahler wrote:
> >
Reviewboard is not letting me update the diff on this one:
>>> Error data: {u'stat': u'fail', u'file': u'src/webui/master/static/bootstrap/js/jquery.js', u'err': {u'msg': u'The file was not found in the repository', u'code': 207}, u'revision': ''}
Will see if a new review is ok.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7855/#review13124
-----------------------------------------------------------
On Nov. 3, 2012, 10:19 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7855/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2012, 10:19 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Saves around 750KB of content to send over the wire, for little effort.
>
>
> Diffs
> -----
>
> src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
> src/webui/master/static/angular-1.0.0rc8.min.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery-1.7.1.min.js PRE-CREATION
> src/webui/master/static/cubism.v1.min.js PRE-CREATION
> src/webui/master/static/d3.v2.min.js PRE-CREATION
> src/webui/master/static/index.html 5e03ef6d054fab962657c1598888e65232f4c7e3
>
> Diff: https://reviews.apache.org/r/7855/diff/
>
>
> Testing
> -------
>
> Local runs, made sure to not forget adding to the Makefile this time.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Using minified javascript in the webui.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7855/#review13124
-----------------------------------------------------------
src/Makefile.am
<https://reviews.apache.org/r/7855/#comment28283>
Yep, done.
Weird that they don't include it in their filenames.
- Ben Mahler
On Nov. 3, 2012, 10:19 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7855/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2012, 10:19 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Saves around 750KB of content to send over the wire, for little effort.
>
>
> Diffs
> -----
>
> src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
> src/webui/master/static/angular-1.0.0rc8.min.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery-1.7.1.min.js PRE-CREATION
> src/webui/master/static/cubism.v1.min.js PRE-CREATION
> src/webui/master/static/d3.v2.min.js PRE-CREATION
> src/webui/master/static/index.html 5e03ef6d054fab962657c1598888e65232f4c7e3
>
> Diff: https://reviews.apache.org/r/7855/diff/
>
>
> Testing
> -------
>
> Local runs, made sure to not forget adding to the Makefile this time.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Using minified javascript in the webui.
Posted by Ben Mahler <be...@gmail.com>.
> On Nov. 5, 2012, 10:50 p.m., Benjamin Hindman wrote:
> > src/Makefile.am, line 365
> > <https://reviews.apache.org/r/7855/diff/1/?file=185197#file185197line365>
> >
> > Wasn't this reformatting in a different review?
>
> Ben Mahler wrote:
> Yep, but this will conflict either way since I'm adding files in here..
> Figured the merge is simpler with me duplicating the formatting fix.
>
> Benjamin Hindman wrote:
> I don't follow. If the other commit gets applied first, adding lines should apply cleanly. However, attempting to reformat _and_ adding lines will not apply at all.
I don't think it's possible to get this to patch, since I want to keep it alphabetical:
Before:
nobase_dist_webui_DATA += webui/master/static/angular-1.0.0rc8.js \
webui/master/static/underscore.js \
webui/master/static/cubism.v1.js webui/master/static/d3.v2.js \
webui/master/static/relative-date.js
It's not purely a matter of adding lines, I've got to insert cubism.v1.min.js after cubism, modifying the same line as the other review.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7855/#review13112
-----------------------------------------------------------
On Nov. 6, 2012, 6:23 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7855/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2012, 6:23 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Saves around 750KB of content to send over the wire, for little effort.
>
>
> Diffs
> -----
>
> src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
> src/webui/master/static/angular-1.0.0rc8.min.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery-1.7.1.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery-1.7.1.min.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery.js 00c4e23a27b15f6158ea46a016beb0ae95c6596d
> src/webui/master/static/cubism.v1.min.js PRE-CREATION
> src/webui/master/static/d3.v2.min.js PRE-CREATION
> src/webui/master/static/index.html 5e03ef6d054fab962657c1598888e65232f4c7e3
> src/webui/master/static/pailer.html 80dcd7b349582cb1875d1a72745c9c22394c0a26
> src/webui/master/static/underscore-1.3.3.min.js PRE-CREATION
> src/webui/master/static/underscore-min.js 5a0cb3b008d213ef3ecd3147c51eed08d98e2c54
>
> Diff: https://reviews.apache.org/r/7855/diff/
>
>
> Testing
> -------
>
> Local runs, made sure to not forget adding to the Makefile this time.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Using minified javascript in the webui.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Nov. 5, 2012, 10:50 p.m., Benjamin Hindman wrote:
> > src/Makefile.am, line 365
> > <https://reviews.apache.org/r/7855/diff/1/?file=185197#file185197line365>
> >
> > Wasn't this reformatting in a different review?
>
> Ben Mahler wrote:
> Yep, but this will conflict either way since I'm adding files in here..
> Figured the merge is simpler with me duplicating the formatting fix.
I don't follow. If the other commit gets applied first, adding lines should apply cleanly. However, attempting to reformat _and_ adding lines will not apply at all.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7855/#review13112
-----------------------------------------------------------
On Nov. 6, 2012, 6:23 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7855/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2012, 6:23 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Saves around 750KB of content to send over the wire, for little effort.
>
>
> Diffs
> -----
>
> src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
> src/webui/master/static/angular-1.0.0rc8.min.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery-1.7.1.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery-1.7.1.min.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery.js 00c4e23a27b15f6158ea46a016beb0ae95c6596d
> src/webui/master/static/cubism.v1.min.js PRE-CREATION
> src/webui/master/static/d3.v2.min.js PRE-CREATION
> src/webui/master/static/index.html 5e03ef6d054fab962657c1598888e65232f4c7e3
> src/webui/master/static/pailer.html 80dcd7b349582cb1875d1a72745c9c22394c0a26
> src/webui/master/static/underscore-1.3.3.min.js PRE-CREATION
> src/webui/master/static/underscore-min.js 5a0cb3b008d213ef3ecd3147c51eed08d98e2c54
>
> Diff: https://reviews.apache.org/r/7855/diff/
>
>
> Testing
> -------
>
> Local runs, made sure to not forget adding to the Makefile this time.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Using minified javascript in the webui.
Posted by Ben Mahler <be...@gmail.com>.
> On Nov. 5, 2012, 10:50 p.m., Benjamin Hindman wrote:
> > src/Makefile.am, line 365
> > <https://reviews.apache.org/r/7855/diff/1/?file=185197#file185197line365>
> >
> > Wasn't this reformatting in a different review?
Yep, but this will conflict either way since I'm adding files in here..
Figured the merge is simpler with me duplicating the formatting fix.
> On Nov. 5, 2012, 10:50 p.m., Benjamin Hindman wrote:
> > src/Makefile.am, line 421
> > <https://reviews.apache.org/r/7855/diff/1/?file=185197#file185197line421>
> >
> > Is this jquery-1.7.1? I want to make sure people that are debugging stuff will be looking at the correct version (since they won't debug by looking at the min code). If it is, please rename this file to include the version number. If not, please replace this file with the jquery-1.7.1 version (named appropriately).
Renamed.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7855/#review13112
-----------------------------------------------------------
On Nov. 3, 2012, 10:19 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7855/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2012, 10:19 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Saves around 750KB of content to send over the wire, for little effort.
>
>
> Diffs
> -----
>
> src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
> src/webui/master/static/angular-1.0.0rc8.min.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery-1.7.1.min.js PRE-CREATION
> src/webui/master/static/cubism.v1.min.js PRE-CREATION
> src/webui/master/static/d3.v2.min.js PRE-CREATION
> src/webui/master/static/index.html 5e03ef6d054fab962657c1598888e65232f4c7e3
>
> Diff: https://reviews.apache.org/r/7855/diff/
>
>
> Testing
> -------
>
> Local runs, made sure to not forget adding to the Makefile this time.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Using minified javascript in the webui.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7855/#review13112
-----------------------------------------------------------
src/Makefile.am
<https://reviews.apache.org/r/7855/#comment28246>
Wasn't this reformatting in a different review?
src/Makefile.am
<https://reviews.apache.org/r/7855/#comment28247>
Does underscore have a version too? It would be great to include the version number if applicable.
src/Makefile.am
<https://reviews.apache.org/r/7855/#comment28248>
Is this jquery-1.7.1? I want to make sure people that are debugging stuff will be looking at the correct version (since they won't debug by looking at the min code). If it is, please rename this file to include the version number. If not, please replace this file with the jquery-1.7.1 version (named appropriately).
- Benjamin Hindman
On Nov. 3, 2012, 10:19 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7855/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2012, 10:19 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Saves around 750KB of content to send over the wire, for little effort.
>
>
> Diffs
> -----
>
> src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
> src/webui/master/static/angular-1.0.0rc8.min.js PRE-CREATION
> src/webui/master/static/bootstrap/js/jquery-1.7.1.min.js PRE-CREATION
> src/webui/master/static/cubism.v1.min.js PRE-CREATION
> src/webui/master/static/d3.v2.min.js PRE-CREATION
> src/webui/master/static/index.html 5e03ef6d054fab962657c1598888e65232f4c7e3
>
> Diff: https://reviews.apache.org/r/7855/diff/
>
>
> Testing
> -------
>
> Local runs, made sure to not forget adding to the Makefile this time.
>
>
> Thanks,
>
> Ben Mahler
>
>