You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/22 16:58:09 UTC

[GitHub] [airflow] kaxil opened a new pull request #17167: Doc: Add hyperlinks to Github PRs for Chart Changelog

kaxil opened a new pull request #17167:
URL: https://github.com/apache/airflow/pull/17167

This uses same logic as the core "apache-airflow" docs to add Hyperlinks

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #17167: Doc: Add hyperlinks to Github PRs for Chart Changelog

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #17167:
URL: https://github.com/apache/airflow/pull/17167#issuecomment-885073068


   The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil merged pull request #17167: Doc: Add hyperlinks to Github PRs for Chart Changelog

Posted by GitBox <gi...@apache.org>.

kaxil merged pull request #17167:
URL: https://github.com/apache/airflow/pull/17167


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on a change in pull request #17167: Doc: Add hyperlinks to Github PRs for Chart Changelog

Posted by GitBox <gi...@apache.org>.

kaxil commented on a change in pull request #17167:
URL: https://github.com/apache/airflow/pull/17167#discussion_r675020066



##########
File path: docs/conf.py
##########
@@ -240,16 +240,16 @@ def _get_rst_filepath_from_path(filepath: str):
 # Add any paths that contain custom static files (such as style sheets) here,
 # relative to this directory. They are copied after the builtin static files,
 # so a file named "default.css" will overwrite the builtin "default.css".
-if PACKAGE_NAME == 'apache-airflow':
-    html_static_path = ['apache-airflow/static']
+if PACKAGE_NAME in ['apache-airflow', 'helm-chart']:
+    html_static_path = [f'{PACKAGE_NAME}/static']

Review comment:
       Yup, currently all our docs are isolated -- but we could do something with shared/common pieces




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] o-nikolas commented on a change in pull request #17167: Doc: Add hyperlinks to Github PRs for Chart Changelog

Posted by GitBox <gi...@apache.org>.

o-nikolas commented on a change in pull request #17167:
URL: https://github.com/apache/airflow/pull/17167#discussion_r675014512



##########
File path: docs/conf.py
##########
@@ -240,16 +240,16 @@ def _get_rst_filepath_from_path(filepath: str):
 # Add any paths that contain custom static files (such as style sheets) here,
 # relative to this directory. They are copied after the builtin static files,
 # so a file named "default.css" will overwrite the builtin "default.css".
-if PACKAGE_NAME == 'apache-airflow':
-    html_static_path = ['apache-airflow/static']
+if PACKAGE_NAME in ['apache-airflow', 'helm-chart']:
+    html_static_path = [f'{PACKAGE_NAME}/static']

Review comment:
       +1
   These scripts look like they are almost entirely duplicates? I may be misunderstanding something.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham commented on a change in pull request #17167: Doc: Add hyperlinks to Github PRs for Chart Changelog

Posted by GitBox <gi...@apache.org>.

jedcunningham commented on a change in pull request #17167:
URL: https://github.com/apache/airflow/pull/17167#discussion_r674994087



##########
File path: docs/conf.py
##########
@@ -240,16 +240,16 @@ def _get_rst_filepath_from_path(filepath: str):
 # Add any paths that contain custom static files (such as style sheets) here,
 # relative to this directory. They are copied after the builtin static files,
 # so a file named "default.css" will overwrite the builtin "default.css".
-if PACKAGE_NAME == 'apache-airflow':
-    html_static_path = ['apache-airflow/static']
+if PACKAGE_NAME in ['apache-airflow', 'helm-chart']:
+    html_static_path = [f'{PACKAGE_NAME}/static']

Review comment:
       Should we have a `common` or `shared` instead of duplicating the script? Maybe in a follow up?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on a change in pull request #17167: Doc: Add hyperlinks to Github PRs for Chart Changelog

Posted by GitBox <gi...@apache.org>.

kaxil commented on a change in pull request #17167:
URL: https://github.com/apache/airflow/pull/17167#discussion_r675020066



##########
File path: docs/conf.py
##########
@@ -240,16 +240,16 @@ def _get_rst_filepath_from_path(filepath: str):
 # Add any paths that contain custom static files (such as style sheets) here,
 # relative to this directory. They are copied after the builtin static files,
 # so a file named "default.css" will overwrite the builtin "default.css".
-if PACKAGE_NAME == 'apache-airflow':
-    html_static_path = ['apache-airflow/static']
+if PACKAGE_NAME in ['apache-airflow', 'helm-chart']:
+    html_static_path = [f'{PACKAGE_NAME}/static']

Review comment:
       Yup, currently all our docs are isolated -- but we could do something with shared/common pieces separately




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org