You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Karl Wright (JIRA)" <ji...@apache.org> on 2016/04/08 13:53:25 UTC
[jira] [Comment Edited] (LUCENE-7192) Geo3d polygon creation should
not get upset about co-linear points
[ https://issues.apache.org/jira/browse/LUCENE-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232066#comment-15232066 ]
Karl Wright edited comment on LUCENE-7192 at 4/8/16 11:52 AM:
--------------------------------------------------------------
Here's another one. This looks in fact like a bug:
{code}
[junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestGeo3DPoint -Dtests.method=testRandomTiny -Dtests.seed=3CF56281893AB530 -Dtests.slow=true -Dtests.locale=hr-HR -Dtests.timezone=America/Boise -Dtests.asserts=true -Dtests.file.encoding=Cp1252
[junit4] ERROR 0.68s J0 | TestGeo3DPoint.testRandomTiny <<<
[junit4] > Throwable #1: java.lang.IllegalArgumentException: Polygon needs at least three points.
[junit4] > at __randomizedtesting.SeedInfo.seed([3CF56281893AB530:75B2BCC7D71B8D9C]:0)
[junit4] > at org.apache.lucene.spatial3d.geom.GeoConvexPolygon.done(GeoConvexPolygon.java:171)
[junit4] > at org.apache.lucene.spatial3d.geom.GeoConvexPolygon.<init>(GeoConvexPolygon.java:110)
[junit4] > at org.apache.lucene.spatial3d.geom.GeoPolygonFactory.findConvexPolygon(GeoPolygonFactory.java:771)
[junit4] > at org.apache.lucene.spatial3d.geom.GeoPolygonFactory.buildPolygonShape(GeoPolygonFactory.java:356)
[junit4] > at org.apache.lucene.spatial3d.geom.GeoPolygonFactory.buildPolygonShape(GeoPolygonFactory.java:477)
[junit4] > at org.apache.lucene.spatial3d.geom.GeoPolygonFactory.makeGeoPolygon(GeoPolygonFactory.java:156)
[junit4] > at org.apache.lucene.spatial3d.geom.GeoPolygonFactory.makeGeoPolygon(GeoPolygonFactory.java:119)
[junit4] > at org.apache.lucene.spatial3d.Geo3DPoint.fromPolygon(Geo3DPoint.java:208)
[junit4] > at org.apache.lucene.spatial3d.Geo3DPoint.newPolygonQuery(Geo3DPoint.java:142)
[junit4] > at org.apache.lucene.spatial3d.TestGeo3DPoint.random3DQuery(TestGeo3DPoint.java:530)
[junit4] > at org.apache.lucene.spatial3d.TestGeo3DPoint.verify(TestGeo3DPoint.java:736)
[junit4] > at org.apache.lucene.spatial3d.TestGeo3DPoint.doTestRandom(TestGeo3DPoint.java:517)
[junit4] > at org.apache.lucene.spatial3d.TestGeo3DPoint.testRandomTiny(TestGeo3DPoint.java:440)
[junit4] > at java.lang.Thread.run(Thread.java:745)
[junit4] IGNOR/A 0.01s J0 | TestGeo3DPoint.testRandomBig
[junit4] > Assumption #1: 'nightly' test group is disabled (@Nightly())
{code}
was (Author: kwright@metacarta.com):
Here's another one. This looks in fact like a bug:
{quote}
[junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestGeo3DPoint -Dtests.method=testRandomTiny -Dtests.seed=3CF56281893AB530 -Dtests.slow=true -Dtests.locale=hr-HR -Dtests.timezone=America/Boise -Dtests.asserts=true -Dtests.file.encoding=Cp1252
[junit4] ERROR 0.68s J0 | TestGeo3DPoint.testRandomTiny <<<
[junit4] > Throwable #1: java.lang.IllegalArgumentException: Polygon needs at least three points.
[junit4] > at __randomizedtesting.SeedInfo.seed([3CF56281893AB530:75B2BCC7D71B8D9C]:0)
[junit4] > at org.apache.lucene.spatial3d.geom.GeoConvexPolygon.done(GeoConvexPolygon.java:171)
[junit4] > at org.apache.lucene.spatial3d.geom.GeoConvexPolygon.<init>(GeoConvexPolygon.java:110)
[junit4] > at org.apache.lucene.spatial3d.geom.GeoPolygonFactory.findConvexPolygon(GeoPolygonFactory.java:771)
[junit4] > at org.apache.lucene.spatial3d.geom.GeoPolygonFactory.buildPolygonShape(GeoPolygonFactory.java:356)
[junit4] > at org.apache.lucene.spatial3d.geom.GeoPolygonFactory.buildPolygonShape(GeoPolygonFactory.java:477)
[junit4] > at org.apache.lucene.spatial3d.geom.GeoPolygonFactory.makeGeoPolygon(GeoPolygonFactory.java:156)
[junit4] > at org.apache.lucene.spatial3d.geom.GeoPolygonFactory.makeGeoPolygon(GeoPolygonFactory.java:119)
[junit4] > at org.apache.lucene.spatial3d.Geo3DPoint.fromPolygon(Geo3DPoint.java:208)
[junit4] > at org.apache.lucene.spatial3d.Geo3DPoint.newPolygonQuery(Geo3DPoint.java:142)
[junit4] > at org.apache.lucene.spatial3d.TestGeo3DPoint.random3DQuery(TestGeo3DPoint.java:530)
[junit4] > at org.apache.lucene.spatial3d.TestGeo3DPoint.verify(TestGeo3DPoint.java:736)
[junit4] > at org.apache.lucene.spatial3d.TestGeo3DPoint.doTestRandom(TestGeo3DPoint.java:517)
[junit4] > at org.apache.lucene.spatial3d.TestGeo3DPoint.testRandomTiny(TestGeo3DPoint.java:440)
[junit4] > at java.lang.Thread.run(Thread.java:745)
[junit4] IGNOR/A 0.01s J0 | TestGeo3DPoint.testRandomBig
[junit4] > Assumption #1: 'nightly' test group is disabled (@Nightly())
{quote}
> Geo3d polygon creation should not get upset about co-linear points
> ------------------------------------------------------------------
>
> Key: LUCENE-7192
> URL: https://issues.apache.org/jira/browse/LUCENE-7192
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial3d
> Affects Versions: master
> Reporter: Karl Wright
> Assignee: Karl Wright
>
> Currently, if you create a polygon with co-linear adjacent points, the polygon fails to create (you get IllegalArgumentException). We should make this more robust.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org