You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/06 16:24:41 UTC
[GitHub] [airflow] ashb opened a new pull request #12856: Mark required fields in Forms as required
ashb opened a new pull request #12856:
URL: https://github.com/apache/airflow/pull/12856
We have a number of custom forms that have required fields that weren't
explicitly marked as required.
This allowed you to submit the Connection form (for example) with
nothing as the Conn Id, leading to an empty string being used as the
connection id. This marks that and all the other required fields as
required.
We also replace DataRequired with InputRequired. The previous one is
tested the truthyness of the value, rather than just that a value was
submitted.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #12856: Mark required fields in Forms as required
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #12856:
URL: https://github.com/apache/airflow/pull/12856#discussion_r537105288
##########
File path: airflow/www/forms.py
##########
@@ -194,9 +201,12 @@ class TaskInstanceEditForm(DynamicForm):
('up_for_retry', 'up_for_retry'),
),
widget=Select2Widget(),
+ validators=[InputRequired()],
)
execution_date = DateTimeWithTimezoneField(
- lazy_gettext('Execution Date'), widget=AirflowDateTimePickerROWidget()
+ lazy_gettext('Execution Date'),
+ widget=AirflowDateTimePickerROWidget(),
+ validators=[InputRequired()],
Review comment:
I guess it's optional, but this means there's a nice red `*` so it's consistent.
In short: no harm, could leave or remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #12856: Mark required fields in Forms as required
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #12856:
URL: https://github.com/apache/airflow/pull/12856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12856: Mark required fields in Forms as required
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12856:
URL: https://github.com/apache/airflow/pull/12856#issuecomment-739570101
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #12856: Mark required fields in Forms as required
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #12856:
URL: https://github.com/apache/airflow/pull/12856#discussion_r537092783
##########
File path: airflow/www/forms.py
##########
@@ -194,9 +201,12 @@ class TaskInstanceEditForm(DynamicForm):
('up_for_retry', 'up_for_retry'),
),
widget=Select2Widget(),
+ validators=[InputRequired()],
)
execution_date = DateTimeWithTimezoneField(
- lazy_gettext('Execution Date'), widget=AirflowDateTimePickerROWidget()
+ lazy_gettext('Execution Date'),
+ widget=AirflowDateTimePickerROWidget(),
+ validators=[InputRequired()],
Review comment:
This is a read only field so I don't think we need validators here, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org