[GitHub] spark pull request: SPARK-1639. Tidy up some Spark on YARN code

[tgravescs <gi...@git.apache.org>]

Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/561#discussion_r13402400
  
    --- Diff: yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ---
    @@ -467,13 +467,22 @@ object ApplicationMaster {
           })
         }
     
    -    // Wait for initialization to complete and atleast 'some' nodes can get allocated.
    +    modified
    +  }
    +
    +
    +  /**
    +   * Returns when we've either
    +   *  1) received all the requested executors,
    +   *  2) waited ALLOCATOR_LOOP_WAIT_COUNT * ALLOCATE_HEARTBEAT_INTERVAL ms,
    --- End diff --
    
    ALLOCATE_HEARTBEAT_INTERVAL only exists in stable so either add it in alpha or update comment to 100ms.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---